Skip to content

Use assert_close in tests #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use assert_close in tests #429

wants to merge 4 commits into from

Conversation

Edenzzzz
Copy link
Collaborator

Supersedes #426

@Edenzzzz Edenzzzz temporarily deployed to runpod-runners May 24, 2025 00:09 — with GitHub Actions Inactive
@Edenzzzz Edenzzzz changed the title Use assert_close in tests & download to default cache location #426 Use assert_close in tests & download to default cache location May 24, 2025
@Edenzzzz Edenzzzz mentioned this pull request May 29, 2025
Merged
2 tasks
SolitaryThinker
SolitaryThinker reviewed May 29, 2025
View reviewed changes
@SolitaryThinker
Copy link
Collaborator

Otherwise your assert_close changes look good. Your commend in the preprocessing PR is also correct and we shouldn't use local_dir for preprocess code

SolitaryThinker
SolitaryThinker approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@SolitaryThinker SolitaryThinker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about let's revert the local_dir changes for downloading and merge this PR after CI passes?

@Edenzzzz Edenzzzz temporarily deployed to runpod-runners May 31, 2025 01:22 — with GitHub Actions Inactive
@Edenzzzz Edenzzzz changed the title Use assert_close in tests & download to default cache location Use assert_close in tests Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SolitaryThinker SolitaryThinker SolitaryThinker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Edenzzzz @SolitaryThinker