Skip to content

Conversation

jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented Sep 15, 2025

No description provided.

jkiddo and others added 30 commits August 4, 2025 11:26
Reuse FhirContext in result serialization
# Conflicts:
#	src/main/resources/application.yaml
@robogary
Copy link

Formatting check succeeded!

# Conflicts:
#	pom.xml
#	src/main/java/ca/uhn/fhir/jpa/starter/mcp/McpServerConfig.java
#	src/main/resources/application.yaml
#	src/test/java/ca/uhn/fhir/jpa/starter/McpTests.java
@jkiddo jkiddo requested review from barhodes and Copilot September 26, 2025 17:12
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements configuration classes for the Clinical Decision Support (CDS) features in the HAPI FHIR starter, specifically focusing on Clinical Quality Language (CQL) and CDS Hooks functionality.

  • Refactors configuration properties to use proper Spring Boot @ConfigurationProperties annotations
  • Creates separate configuration classes for different CDS domains (terminology, compiler, runtime, data)
  • Restructures the application.yaml file for better organization and documentation
  • Disables a failing test temporarily

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
CdsHooksServletIT.java Disables failing test testRec10()
application.yaml Major reorganization with improved comments and structure
CrProperties.java Adds @ConfigurationProperties annotation and removes default initialization
CrCommonConfig.java Refactors bean creation to use new configuration structure
CqlTerminologyProperties.java New configuration class for CQL terminology settings
CqlRuntimeProperties.java Adds @ConfigurationProperties annotation
CqlProperties.java Updates to use new configuration structure
CqlData.java New configuration class for CQL data settings
CqlCompilerProperties.java Adds @ConfigurationProperties annotation
CareGapsProperties.java Adds @ConfigurationProperties annotation
StarterCdsHooksConfig.java Simplifies imports and updates bean dependencies
ProviderConfiguration.java Updates constructor to use new property structure
CdsHooksServlet.java Removes unused RestfulServer dependency
CdsHooksProperties.java Adds @configuration annotation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +12 to +13
private CareGapsProperties careGaps;
private CqlProperties cql;
Copy link
Preview

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields are now null by default and could cause NullPointerException when accessed. Consider either initializing them with default instances or adding null checks in the getters.

Copilot uses AI. Check for mistakes.

private CqlCompilerProperties compiler;
private CqlRuntimeProperties runtime;
private TerminologySettings terminology;
private CqlData data;
Copy link
Preview

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fields are now null by default and could cause NullPointerException when accessed through their getters. Consider initializing them with default instances or adding null checks.

Suggested change
private CqlData data;
private CqlData data = new CqlData();

Copilot uses AI. Check for mistakes.

@jkiddo jkiddo marked this pull request as ready for review September 26, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants