-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Feature/cds config #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/cds config #857
Conversation
Reuse FhirContext in result serialization
…tarter into feature/mcp
PoC tool for CDS Hooks
# Conflicts: # src/main/resources/application.yaml
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Formatting check succeeded! |
# Conflicts: # pom.xml # src/main/java/ca/uhn/fhir/jpa/starter/mcp/McpServerConfig.java # src/main/resources/application.yaml # src/test/java/ca/uhn/fhir/jpa/starter/McpTests.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements configuration classes for the Clinical Decision Support (CDS) features in the HAPI FHIR starter, specifically focusing on Clinical Quality Language (CQL) and CDS Hooks functionality.
- Refactors configuration properties to use proper Spring Boot @ConfigurationProperties annotations
- Creates separate configuration classes for different CDS domains (terminology, compiler, runtime, data)
- Restructures the application.yaml file for better organization and documentation
- Disables a failing test temporarily
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
CdsHooksServletIT.java | Disables failing test testRec10() |
application.yaml | Major reorganization with improved comments and structure |
CrProperties.java | Adds @ConfigurationProperties annotation and removes default initialization |
CrCommonConfig.java | Refactors bean creation to use new configuration structure |
CqlTerminologyProperties.java | New configuration class for CQL terminology settings |
CqlRuntimeProperties.java | Adds @ConfigurationProperties annotation |
CqlProperties.java | Updates to use new configuration structure |
CqlData.java | New configuration class for CQL data settings |
CqlCompilerProperties.java | Adds @ConfigurationProperties annotation |
CareGapsProperties.java | Adds @ConfigurationProperties annotation |
StarterCdsHooksConfig.java | Simplifies imports and updates bean dependencies |
ProviderConfiguration.java | Updates constructor to use new property structure |
CdsHooksServlet.java | Removes unused RestfulServer dependency |
CdsHooksProperties.java | Adds @configuration annotation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
private CareGapsProperties careGaps; | ||
private CqlProperties cql; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields are now null by default and could cause NullPointerException when accessed. Consider either initializing them with default instances or adding null checks in the getters.
Copilot uses AI. Check for mistakes.
private CqlCompilerProperties compiler; | ||
private CqlRuntimeProperties runtime; | ||
private TerminologySettings terminology; | ||
private CqlData data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fields are now null by default and could cause NullPointerException when accessed through their getters. Consider initializing them with default instances or adding null checks.
private CqlData data; | |
private CqlData data = new CqlData(); |
Copilot uses AI. Check for mistakes.
No description provided.