-
Notifications
You must be signed in to change notification settings - Fork 1.4k
7324 unable to access collection bundles when performing search requests #7325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rel_8_6
Are you sure you want to change the base?
7324 unable to access collection bundles when performing search requests #7325
Conversation
|
Formatting check succeeded! |
…when-performing-search-requests
…when-performing-search-requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending a couple comments
| @MethodSource(value = "getReadStandaloneBundleInTransactionArguments") | ||
| public void testReadCollectionBundleInTransaction(AuthorizationInterceptor theAuthorizationInterceptor, boolean theShouldAllow) { | ||
| Bundle collectionBundle = createCollectionBundle(createPatient("John", "Smith")); | ||
| createCollectionBundle(createPatient("Jane", "Doe")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the second createCollectionBundle() call needed?
| assertThat(searchResults.getEntry()).as("Should find both COLLECTION and DOCUMENT bundles with TEST-TAG-1").hasSize(1); | ||
|
|
||
| // Search for bundles with TEST-TAG-2 should fail (no authorization) | ||
| assertSearchFailsWith403Forbidden("/Bundle?_tag=http//myserver.ca/provider-1|TEST-TAG-2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend adding a test case here for a /Bundle search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codeql changes look OK to me
collectionto STANDALONE_BUNDLE_RESOURCE_TYPES to accept Bundle permissions