Skip to content

Conversation

@jmarchionatto
Copy link
Collaborator

@jmarchionatto jmarchionatto commented Oct 23, 2025

  • Include collection to STANDALONE_BUNDLE_RESOURCE_TYPES to accept Bundle permissions
  • Also, replace CodeQL autobuild by manual build to avoid Maven wrapper issues

@robogary
Copy link
Contributor

Formatting check succeeded!

@jmarchionatto jmarchionatto changed the base branch from master to rel_8_6 October 24, 2025 14:01
Copy link
Collaborator

@nathandoef nathandoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a couple comments

@MethodSource(value = "getReadStandaloneBundleInTransactionArguments")
public void testReadCollectionBundleInTransaction(AuthorizationInterceptor theAuthorizationInterceptor, boolean theShouldAllow) {
Bundle collectionBundle = createCollectionBundle(createPatient("John", "Smith"));
createCollectionBundle(createPatient("Jane", "Doe"));
Copy link
Collaborator

@nathandoef nathandoef Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the second createCollectionBundle() call needed?

assertThat(searchResults.getEntry()).as("Should find both COLLECTION and DOCUMENT bundles with TEST-TAG-1").hasSize(1);

// Search for bundles with TEST-TAG-2 should fail (no authorization)
assertSearchFailsWith403Forbidden("/Bundle?_tag=http//myserver.ca/provider-1|TEST-TAG-2");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would recommend adding a test case here for a /Bundle search

Copy link
Collaborator

@tadgh tadgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeql changes look OK to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable To Access Collection Bundles When performing SEARCH Requests

5 participants