Bidi Page Event Close

lib/PuppeteerSharp.Nunit/TestExpectations/TestExpectations.local.json

@@ -975,21 +975,6 @@
       "FAIL"
     ]
   },
-  {
-    "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
-    "testIdPattern": "[page.spec] *Page.Events.Close*",
-    "platforms": [
-      "darwin",
-      "linux",
-      "win32"
-    ],
-    "parameters": [
-      "webDriverBiDi"
-    ],
-    "expectations": [
-      "FAIL"
-    ]
-  },
   {
     "comment": "This is part of organizing the webdriver bidi implementation, We will remove it one by one",
     "testIdPattern": "[page.spec] *Page.Events.Console*",

lib/PuppeteerSharp/Bidi/BidiPage.cs

@@ -547,5 +547,9 @@ private async Task<IResponse> GoAsync(int delta, NavigationOptions options)
 
     private void Initialize()
     {
+        BidiMainFrame.BrowsingContext.Closed += (_, _) =>
+        {
+            OnClose();
+        };
     }
 }

lib/PuppeteerSharp/Bidi/Core/BrowsingContext.cs

@@ -71,7 +71,7 @@ private BrowsingContext(UserContext userContext, BrowsingContext parent, string
 
     public string Url { get; private set; }
 
-    public bool IsClosed => _reason != null;
+    public bool IsClosed { get; private set; }
 
     public Session Session => UserContext.Browser.Session;
 
@@ -107,6 +107,13 @@ public static BrowsingContext From(UserContext userContext, BrowsingContext pare
 
     public void Dispose()
     {
+        if (IsClosed)
+        {
+            return;
+        }
+
+        IsClosed = true;
+
         _reason ??= "Browser was disconnected, probably because the session ended.";
         OnClosed(_reason);
         foreach (var context in _children.Values)
@@ -223,7 +230,7 @@ private void Initialize()
 
         Session.BrowsingContextContextDestroyed += (_, args) =>
         {
-            if (args.UserContextId != Id)
+            if (args.BrowsingContextId != Id)
             {
                 return;
             }