Skip to content

Update CSS selector for schedule container #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update CSS selector for schedule container #2014

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01ea9e5
Update CSS selector for schedule container
anishTP Apr 8, 2024
a3debd5
Fixed the upcoming date header and removed past event dates from the …
anishTP Apr 8, 2024
9a93cc1
Lazyload the div containing the upcoming schedule table
anishTP Apr 11, 2024
7e9bbee
update css class reference to lazyload
anishTP Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions funnel/assets/sass/pages/schedule.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,15 @@
max-height: 50vh;
overflow: scroll;
}
.schedule-grid.schedule-grid--compressed .schedule .schedule__table .schedule__row {
content-visibility: auto;
}
.schedule-grid.schedule-grid--compressed .schedule .schedule__date {
display: none;
}
.schedule-grid.schedule-grid--compressed .schedule .schedule__date--upcoming {
display: block;
}
Comment on lines +276 to +281
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inefficient because the backend is still expending compute power to calculate and render the schedule. If the schedule is not being shown, the code should be skipped.

What we need: a "show previous" action that loads the previous schedule.

}

.calendar-wrapper {
Expand Down