Skip to content

Conversation

alexbacchin
Copy link
Contributor

@alexbacchin alexbacchin commented Aug 29, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.
No

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No

Description

This data source returns the GetAccountInformation action from AWS Account Management API. Mostly focus on returning the account_name attribute

Relations

Closes #42386

References

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/account#Client.GetAccountInformation

Output from Acceptance Testing

% make testacc TESTS=TestAccAccount_serial PKG=account 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/account/... -v -count 1 -parallel 20 -run='TestAccAccount_serial'  -timeout 360m -vet=off
2025/08/29 22:23:30 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/29 22:23:30 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccAccount_serial
=== PAUSE TestAccAccount_serial
=== CONT  TestAccAccount_serial
=== RUN   TestAccAccount_serial/Account
=== RUN   TestAccAccount_serial/Account/dataSourceBasic
=== RUN   TestAccAccount_serial/Account/dataSourceAccountID
=== RUN   TestAccAccount_serial/AlternateContact
=== RUN   TestAccAccount_serial/AlternateContact/basic
=== RUN   TestAccAccount_serial/AlternateContact/disappears
=== RUN   TestAccAccount_serial/AlternateContact/AccountID
=== RUN   TestAccAccount_serial/PrimaryContact
=== RUN   TestAccAccount_serial/PrimaryContact/basic
=== RUN   TestAccAccount_serial/PrimaryContact/dataSourceBasic
=== RUN   TestAccAccount_serial/PrimaryContact/dataSourceAccountID
=== RUN   TestAccAccount_serial/Region
=== RUN   TestAccAccount_serial/Region/basic
=== RUN   TestAccAccount_serial/Region/AccountID
--- PASS: TestAccAccount_serial (934.10s)
    --- PASS: TestAccAccount_serial/Account (38.66s)
        --- PASS: TestAccAccount_serial/Account/dataSourceBasic (14.42s)
        --- PASS: TestAccAccount_serial/Account/dataSourceAccountID (24.24s)
    --- PASS: TestAccAccount_serial/AlternateContact (103.40s)
        --- PASS: TestAccAccount_serial/AlternateContact/basic (31.76s)
        --- PASS: TestAccAccount_serial/AlternateContact/disappears (18.35s)
        --- PASS: TestAccAccount_serial/AlternateContact/AccountID (53.29s)
    --- PASS: TestAccAccount_serial/PrimaryContact (73.36s)
        --- PASS: TestAccAccount_serial/PrimaryContact/basic (29.38s)
        --- PASS: TestAccAccount_serial/PrimaryContact/dataSourceBasic (16.22s)
        --- PASS: TestAccAccount_serial/PrimaryContact/dataSourceAccountID (27.76s)
    --- PASS: TestAccAccount_serial/Region (718.69s)
        --- PASS: TestAccAccount_serial/Region/basic (362.44s)
        --- PASS: TestAccAccount_serial/Region/AccountID (356.26s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/account    937.701s

...

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 29, 2025
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/account Issues and PRs that pertain to the account service. size/L Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Aug 29, 2025
@alexbacchin alexbacchin marked this pull request as ready for review August 29, 2025 13:50
@alexbacchin alexbacchin requested a review from a team as a code owner August 29, 2025 13:50
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-data-source Introduces a new data source. service/account Issues and PRs that pertain to the account service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: AWS Account Information
2 participants