Skip to content

Conversation

alexbacchin
Copy link
Contributor

@alexbacchin alexbacchin commented Sep 2, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

New resource for RAM customer manager permissions. I kept the resource name short aws_ram_permission as the RAM API GetPermission and ListPermissions actions also return AWS managed permissions.

The policy versioning was implemented as IAM Policy by keeping the last 5 versions before deleting the oldest one.

Relations

Closes #43959

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRAMPermission PKG=ram  
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/ram/... -v -count 1 -parallel 20 -run='TestAccRAMPermission'  -timeout 360m -vet=off
2025/09/08 22:06:38 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/08 22:06:38 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccRAMPermission_basic
=== PAUSE TestAccRAMPermission_basic
=== RUN   TestAccRAMPermission_version
=== PAUSE TestAccRAMPermission_version
=== RUN   TestAccRAMPermission_disappears
=== PAUSE TestAccRAMPermission_disappears
=== CONT  TestAccRAMPermission_basic
=== CONT  TestAccRAMPermission_disappears
=== CONT  TestAccRAMPermission_version
--- PASS: TestAccRAMPermission_disappears (25.36s)
--- PASS: TestAccRAMPermission_basic (27.69s)
--- PASS: TestAccRAMPermission_version (110.43s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ram        114.198s

...

Copy link
Contributor

github-actions bot commented Sep 2, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ram Issues and PRs that pertain to the ram service. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels Sep 2, 2025
@alexbacchin alexbacchin changed the title [WIP] New resource aws_ram_permission New resource aws_ram_permission Sep 8, 2025
@alexbacchin alexbacchin marked this pull request as ready for review September 8, 2025 13:30
@alexbacchin alexbacchin requested a review from a team as a code owner September 8, 2025 13:30
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. new-resource Introduces a new resource. service/ram Issues and PRs that pertain to the ram service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: Create resource for RAM Customer managed permission
2 participants