Update test to key_usage that is supported on a CA certificate. #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorr
force-pushed
the
victorr/vault-33847-key-usage-pki-secret-backend-root-sign-intermediate-update
branch
3 times, most recently
from
472d130 to
c1f8452
Compare
|
@kitography looks like we ended up implementing the same fix, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the test for key_usage to be testing a key_usage that is acceptable on a CA (Certificate Authority) certificate. In general, CA Certificates should not have keys used for things unrelated to their function as CAs (like KeyAgreement).
Community Note