Skip to content

Conversation

thobianchi
Copy link

@thobianchi thobianchi commented Aug 5, 2025

Description

This PR fixes #952
Add sorting for vhosts after read
Add test

Relates OR Closes #952

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'
$ make test TESTARGS='-v -run=TestFlattenRabbitMQSecretBackendRoleVhost_Order'                                                        (orbstack)
==> Checking that code complies with gofmt requirements...
TF_ACC= VAULT_TOKEN= go test -v -run=TestFlattenRabbitMQSecretBackendRoleVhost_Order -timeout 10m ./...
?   	github.com/hashicorp/terraform-provider-vault	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/coverage	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/cmd/generate	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/codegen	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/helper	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/consts	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/internal/identity/entity	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/group	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/identity/mfa	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/pki	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/internal/provider	(cached) [no tests to run]
?   	github.com/hashicorp/terraform-provider-vault/internal/rotation	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/internal/sync	[no test files]
?   	github.com/hashicorp/terraform-provider-vault/schema	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/testutil	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/util	(cached) [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/hashicorp/terraform-provider-vault/util/mountutil	(cached) [no tests to run]
=== RUN   TestFlattenRabbitMQSecretBackendRoleVhost_Order
--- PASS: TestFlattenRabbitMQSecretBackendRoleVhost_Order (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-vault/vault	2.700s
...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@thobianchi thobianchi requested a review from a team as a code owner August 5, 2025 09:02
@thobianchi thobianchi requested a review from keeefer August 5, 2025 09:02
Copy link

hashicorp-cla-app bot commented Aug 5, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@thobianchi
Copy link
Author

@keeefer I've already signed the CLA but the message is doubled and only one of them is green. Is that a problem?

@robmonte
Copy link
Member

Hi @thobianchi

I noticed this change and even the PR description is very similar to the one located here #2474. However yours includes some test updates to the terraform plugin SDK v2. Are you two from the same organization and thus have shared a similar base bugfix, did you base your change on that other PR, or something else?

@thobianchi
Copy link
Author

thobianchi commented Sep 15, 2025

Hey @robmonte we are not from the same org. It's a clone of that PR as that one is stuck for some reason I don't get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change to vault_rabbitmq_secret_backend_role while not needed
2 participants