-
Notifications
You must be signed in to change notification settings - Fork 723
Add GHC Unit ID store to cabal path output
#11266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cabal path outputcabal path output
f077536 to
248e488
Compare
This change modifies the output of `cabal path`, and therefore requires a changelog entry.
This change modifies the output of `cabal path`, and therefore requires a changelog entry.
54ebf30 to
1703168
Compare
This change modifies the output of `cabal path`, and therefore requires a changelog entry.
1703168 to
eae337e
Compare
|
The value of |
This change modifies the output of `cabal path`, and therefore requires a changelog entry.
eae337e to
bb796cb
Compare
|
Also, perhaps we want to print the compiler paired with its abi hash as well? |
Say, something like this? |
The GHC "Project Unit ID" store path has been used in cabal-install since 3.12.1.0. Resolves: haskell#10165
This change modifies the output of `cabal path`, and therefore requires a changelog entry.
Update `compiler-project-unit-id` to `compiler-store-path` in the `cabal path` output, as it is much more clear.
d83bb90 to
e8a1785
Compare
cabal path outputcabal path output
|
exactly! Then the field |
Wait, am I doing abi-hash, as in |
|
Ah, slight misunderstanding! I think adding the output of Assuming |
|
This is a small patch so it'd be a good addition to 3.16.1.0 but there's no reviews :-( |
fendor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add a test to cabal-testsuite/PackageTests/Path/Compiler/cabal.test.hs, roughly like:
void $ cabal "path" ["-z", "--store-dir", "fake-dir", "--compiler-info"]As the output compiler-store-path should be affected by explicit configuration, iirc?
Perhaps it should even be a test in cabal-testsuite/PackageTests/Path/Config/cabal.test.hs, but I think it might be slightly more tricky to come up with a good test.
Otherwise, I think this is a good addition and Ill approve the PR, once the test has been added.
This addds the GHC Project Unit ID store path to the
cabal pathoutput as "project-unit-id". The GHC "Project Unit ID" store path has been used in cabal-install since 3.12.1.0.Example output:
Note that the new value is "project-unit-id", although I'm not 100% this makes sense. Let me know if there's a better name.
EDIT: Changed name to "compiler-store-path"
Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significantin the changelog file.