Skip to content

Add a context parameter for getSignatureHelp #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
Merged

Add a context parameter for getSignatureHelp #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lsp-test/src/Language/LSP/Test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,9 +937,9 @@ getHover doc pos =
in nullToMaybe . getResponseResult <$> request SMethod_TextDocumentHover params

-- | Returns the signature help at the specified position.
getSignatureHelp :: TextDocumentIdentifier -> Position -> Session (Maybe SignatureHelp)
getSignatureHelp doc pos =
let params = SignatureHelpParams doc pos Nothing Nothing
getSignatureHelp :: TextDocumentIdentifier -> Position -> Maybe SignatureHelpContext -> Session (Maybe SignatureHelp)
getSignatureHelp doc pos mCtx =
let params = SignatureHelpParams doc pos Nothing mCtx
in nullToMaybe . getResponseResult <$> request SMethod_TextDocumentSignatureHelp params

-- | Returns the highlighted occurrences of the term at the specified position
Expand Down
2 changes: 1 addition & 1 deletion lsp-test/test/Test.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ main = hspec $ around withDummyServer $ do
describe "getSignatureHelp" $
it "works" $ \(hin, hout) -> runSessionWithHandles hin hout def fullLatestClientCaps "." $ do
doc <- openDoc "test/data/renamePass/Desktop/simple.hs" "haskell"
signatureHelp <- getSignatureHelp doc (Position 22 32)
signatureHelp <- getSignatureHelp doc (Position 22 32) Nothing
liftIO $ signatureHelp `shouldSatisfy` isJust

-- describe "getHighlights" $
Expand Down
Loading