feat: Alert popup when a round is already active/paused #303
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds an alert popup to prevent users from starting a new round when another round is already active or paused in a campaign, enforcing the business rule that only one round can be active at a time.
- Implemented conditional logic to check for existing active/paused rounds before allowing new round creation
- Added a dialog component to display a user-friendly warning message
- Modified the "Add Round" button behavior to trigger the alert when appropriate
Comments suppressed due to low confidence (1)
frontend/src/components/Campaign/ViewCampaign.vue:193
- The variable name
ActiveGoalAlertuses PascalCase which is inconsistent with other ref variables in the component that use camelCase (e.g.,campaignEditMode,showAddRoundForm). Consider renaming toactiveGoalAlert.
const ActiveGoalAlert = ref(false)
| @@ -35,7 +35,7 @@ | |||
| <cdx-button | |||
| v-if="!showAddRoundForm" | |||
| action="progressive" | |||
| @click="addRound" | |||
| @click="campaignRounds.some(r => r.status == 'active' || r.status=='paused') ? (ActiveGoalAlert = true) : addRound()" | |||
There was a problem hiding this comment.
The inline conditional logic in the click handler is complex and hard to read. Consider extracting this logic into a separate method like handleAddRoundClick() for better maintainability.
Copilot uses AI. Check for mistakes.
| </template> | ||
|
|
||
| <script setup> | ||
| import { ref, onMounted } from 'vue' | ||
| import { ref, onMounted, defineComponent } from 'vue' |
There was a problem hiding this comment.
The defineComponent import is added but not used anywhere in the code. This unused import should be removed.
| import { ref, onMounted, defineComponent } from 'vue' | |
| import { ref, onMounted } from 'vue' |
Copilot uses AI. Check for mistakes.
| label: 'Okay', | ||
| actionType: 'progressive' |
There was a problem hiding this comment.
The primaryAction object uses inconsistent indentation (tabs instead of spaces) compared to the rest of the file. Ensure consistent formatting throughout the component.
| label: 'Okay', | |
| actionType: 'progressive' | |
| label: 'Okay', | |
| actionType: 'progressive' |
Copilot uses AI. Check for mistakes.
Description