Skip to content

Feature/mysql db support #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/mysql db support #305

wants to merge 2 commits into from

Conversation

@wavexnani
Copy link

MySQL Replica Database Support

What I Did

  • Implemented MySQL database connectivity for montage.
  • Enabled connection to Wikimedia replica databases.

Flexible Credential Handling

  • Introduced a database section in config.dev.yaml.
  • Prioritizes reading credentials (user, password) from ~/replica.my.cnf (if present and valid).
  • Falls back to username and password from config.dev.yaml if .my.cnf is not used or fails.
  • Ensures the db_url passed to the application is fully self-contained with credentials.

Simplified App Logic

  • Streamlined sqlalchemy.create_engine calls in montage/app.py.
  • app.py now directly uses the complete db_url for engine setup.
  • Ensures MySQL-specific charset and collation are applied.

Resolved Issues Encountered

  • Dependency conflicts (pyvotecore, SQLAlchemy).
  • Circular import between app.py and utils.py.
  • YAML parsing errors in config.dev.yaml.

wavexnani added 2 commits July 26, 2025 17:25
@wavexnani
feat(database): Add MySQL replica support and configure build environ…
d8f19f2 
…ment

Introduces support for MySQL replica connections with flexible
credential handling.

Also, removes the 'monday/' virtual environment from repository
tracking and configures it to be ignored locally via .git/info/exclude
to prevent accidental commits of local environment files.
Ensures project dependencies are managed via requirements.txt and
requirements.in.
@wavexnani
feat(database): Add MySQL replica support with flexible credentials
93bac91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Factor out database url / credentials in config

1 participant

@wavexnani