Refactor publish-rhel.sh

[JackPGreen]

Simplify

The script calls functions in order, most steps only proceed if a certain condition is met. The subsequent step then immediately checks the same condition before proceeding which is redundant.

This is an optimization, it's not a problem.

Example:
wait_for_container_scan:

hazelcast-docker/.github/scripts/publish-rhel.sh

Lines 68 to 69 in 6729095

	elif [[ ${SCAN_STATUS} == "completed" && "${IMAGE_CERTIFIED}" == "true" ]]; then
	echo "Scan passed!" ; return 0

Immediately followed by publish_the_image:

hazelcast-docker/.github/scripts/publish-rhel.sh

Lines 103 to 106 in 6729095

	if [[ ${SCAN_STATUS} != "completed" || "${IMAGE_CERTIFIED}" != "true" ]]; then
	echoerr "Image you are trying to publish did not pass the certification test, its status is \"${SCAN_STATUS}\" and certified is \"${IMAGE_CERTIFIED}\""
	return 1
	fi

wait_for_container_publish:

hazelcast-docker/.github/scripts/publish-rhel.sh

Lines 138 to 146 in 6729095

	IMAGE=$(get_image published)
	IS_PUBLISHED=$(echo "${IMAGE}" | jq -r '.total')
	if [[ ${IS_PUBLISHED} == "1" ]]; then
	echo "Image is published, exiting."
	return 0
	else
	echo "Image is still not published, waiting..."
	fi

Immediately followed by sync_tags:

hazelcast-docker/.github/scripts/publish-rhel.sh

Lines 183 to 189 in 6729095

	IMAGE=$(get_image published)
	IMAGE_EXISTS=$(echo "${IMAGE}" | jq -r '.total')
	if [[ ${IMAGE_EXISTS} == "0" ]]; then
	echo "Image you are trying to sync does not exist."
	return 1
	fi

Finally merged publish_the_image & sync_tags functions as now they are the same.

get_image

get_image took in filter parameters (e.g. deleted, published), because prior to #968, it was filtering by image name and multiple results were expected.

Now that we use IMAGE_ID, there should only be one response.

This also means rather than filtering published on the server-side, we can get the image and check the published status of the response - which allows us to log it for debug purposes.

wait_for_container_publish

In the event of a timeout waiting for a publish, we log the test results since #845
We should also add information on the status of the (publish) request, as this is what helped us identify the root cause of the RedHat publish issues

[nishaatr]

Good change!

[JackPGreen]

@nishaatr I've (substantially) updates this PR and cleared your review accordingly.

[ldziedziul]

Looks good, have you tested it?