feat: enable adding the chart to existing releases #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 10, 2024
unguiculus
requested changes
Oct 9, 2025
|
|
||
| release, _, err = c.Repositories.GetReleaseByTag(context.TODO(), c.owner, c.repo, input.Name) | ||
| if err != nil { | ||
| return fmt.Errorf("getting the existing relase: %w", err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("getting the existing relase: %w", err) | |
| return fmt.Errorf("getting the existing relase: %w", err) |
Suggested change
| return fmt.Errorf("getting the existing relase: %w", err) | |
| return fmt.Errorf("getting the existing release: %w", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently even if the option --skip-existing is not set, upload will fail when the release exists.
This PR makes the behaviour more consistent, when the release was externally created,
chart-release uploadwill upload the charts/assets to the existing release.This enables repositories that collocate the code and the deployments to have a unified release.
cc: @Koenkk