refactor nested stream calls #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! That looks way better. Can you test if it has an impact on performance? Can you also do the same refactor for |
ericmj
force-pushed
the
main
branch
3 times, most recently
from
3a7bf17 to
bc0c95a
Compare
wojtekmach
force-pushed
the
main
branch
2 times, most recently
from
f03ce04 to
1c88d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this method and decided to refactor it. The logic should be the same, but the result will have a different ordering. There's probably a further opportunity to simplify/combine
build_erlang_ref?/2andbuild_erlang_ref?/3