Skip to content

HHH-19732 Fix wrong resetting of owned on-delete action when processing inverse collection #10807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

HHH-19732 Fix wrong resetting of owned on-delete action when processing inverse collection #10807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions hibernate-core/src/main/java/org/hibernate/boot/model/internal/CollectionBinder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import org.hibernate.mapping.Selectable;
import org.hibernate.mapping.SimpleValue;
import org.hibernate.mapping.Table;
import org.hibernate.mapping.ToOne;
import org.hibernate.mapping.Value;
import org.hibernate.metamodel.CollectionClassification;
import org.hibernate.metamodel.UnsupportedMappingException;
Expand Down Expand Up @@ -2702,6 +2703,13 @@ private void bindUnownedManyToManyInverseForeignKey(
manyToOne.setReferencedPropertyName( referencedPropertyName );
metadataCollector.addUniquePropertyReference( targetEntity.getEntityName(), referencedPropertyName );
}
// Ensure that we copy over the delete action from the owner side before creating the foreign key
if ( property.getValue() instanceof Collection collectionValue ) {
manyToOne.setOnDeleteAction( ( (SimpleValue) collectionValue.getKey() ).getOnDeleteAction() );
}
else if ( property.getValue() instanceof ToOne toOne ) {
manyToOne.setOnDeleteAction( toOne.getOnDeleteAction() );
}
manyToOne.setReferenceToPrimaryKey( referencedPropertyName == null );
value.createForeignKey();
}
Expand Down
3 changes: 3 additions & 0 deletions ...ate-core/src/test/java/org/hibernate/orm/test/ondeletecascade/OnDeleteManyToManyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,8 @@ static class A {
static class B {
@Id
long id;
@ManyToMany(mappedBy = "bs")
@OnDelete(action = OnDeleteAction.CASCADE)
Set<A> as = new HashSet<>();
}
}