-
-
Notifications
You must be signed in to change notification settings - Fork 101
Upgrade Hibernate ORM to 7.2.0.CR1 #2625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DavideD
wants to merge
14
commits into
hibernate:main
Choose a base branch
from
DavideD:ORM-7.2.0.CR1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,329
−1,028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return new SessionImpl( delegate, this ); | ||
} | ||
}; | ||
return (SessionCreationOptions) sessionBuilder.tenantIdentifier( tenantIdentifier ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Invoking should be avoided because it has been deprecated.
SessionBuilderImpl.tenantIdentifier
Error loading related location
Loading } | ||
|
||
return javaTypeRegistry.resolveDescriptor( Object[].class ); | ||
return javaTypeRegistry.getDescriptor( Object[].class ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Invoking should be avoided because it has been deprecated.
JavaTypeRegistry.getDescriptor
Error loading related location
Loading
hibernate-reactive-core/src/test/java/org/hibernate/reactive/CascadeTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/CascadeTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/CascadeTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/CascadeTest.java
Fixed
Show fixed
Hide fixed
hibernate-reactive-core/src/test/java/org/hibernate/reactive/CascadeTest.java
Fixed
Show fixed
Hide fixed
… and SessionCreationOptions in 7.2
… to JdbcMetadataAccessStrategy
…nd RuntimeModelCreationContext
Fixes * return the right lock (different than ORM) * Fix postLoad issue
70cbcb8
to
404c2dd
Compare
404c2dd
to
af511bb
Compare
83d1559
to
8bb611f
Compare
I don't know if this test actually makes sense: the cancel opertion happens in a different thread that causes some error when calling session.close because the thread doesn't match the one the session was open. I'm going to keep it because it was introduced to solve hibernate#1436 but we might need to review it again in the future.
8bb611f
to
5a443c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this PR: #2520
Here's a list of the disabled tests: