Add BlazorWebApp to samples #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I spent sometime to resolve this issue but I have many thing to do that's why I late to submit a PR, but I'm glad you did it Hope to review your PR ASAP |
|
Could you please add a functional test while I'm reviewing this? |
added 2 commits
January 13, 2024 11:36
…thHelpers and move the logic to LoadJsonResources
|
@LunaWanderer1 any updates on this? |
|
Hey, haven't had much time to look more into the testing but I noticed the IStringLocalizer doesn't work since it uses FilePaths so that may require more changes |
|
We need to revise this again, so we can take an action quickly |
|
@LunaWanderer1 can we revise this again, sorry for not merging this PR, but PR without testing might breaks anything else, hope you understand my concern |
|
If the issue still exist let me know I will fix it, coz I asked two times to revise this PR but seems you are busy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #79