-
Notifications
You must be signed in to change notification settings - Fork 2
Rwa 4294 task initiate refactor #1489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
void setUp() { | ||
taskId = UUID.randomUUID().toString(); | ||
|
||
taskTestUtils = new TaskTestUtils(cftTaskDatabaseService); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can initiate this on a class level instead of before each test. This comment applies to all tests
private TaskTestUtils taskTestUtils = new TaskTestUtils(cftTaskDatabaseService);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed I made changes as suggested and tested them, Martin. Please verify and let me know if anything needs to be changed.
private RoleAssignmentService roleAssignmentService; | ||
|
||
private String reconfigTaskId; | ||
TaskTestUtils taskTestUtils; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class has initiateTask() method can we reuse any of the methods in TaskTestUtils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, these methods were developed specifically for this test case. Unfortunately, we can't reuse the methods in TaskTest utils for this reason.
Plan Result (aat)
|
Plan Result (prod)
|
# Conflicts: # src/integrationTest/java/uk/gov/hmcts/reform/wataskmanagementapi/controllers/ExecuteReconfigurationTaskOperationControllerTest.java # src/integrationTest/java/uk/gov/hmcts/reform/wataskmanagementapi/services/TaskManagementTimeZoneTest.java
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RWA-4294
Change description
Does this PR introduce a breaking change? (check one with "x")