RWA-4661: Added new test case for complete #1495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larslnde
previously approved these changes
Sep 2, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
BenNzewi
reviewed
Oct 6, 2025
| private ServiceMocks mockServices; | ||
|
|
||
| @Test | ||
| void when_the_task_completed_values_should_reflect_replica_db() throws Exception { |
There was a problem hiding this comment.
As agreed, we should use our test naming convention "Should_ExpectedBehavior_When_StateUnderTest"
There was a problem hiding this comment.
Updated the test case name.
BenNzewi
reviewed
Oct 6, 2025
Added history table assertions. |
MartinYSpasov
requested changes
Oct 16, 2025
|
|
||
| assertEquals(1, reportableTaskList.size()); | ||
| assertEquals("COMPLETED", reportableTaskList.get(0).getState()); | ||
| assertNotNull(reportableTaskList.get(0).getAssignee()); |
There was a problem hiding this comment.
Majority of assertNotNull assertions can use real values
|
|
||
| assertEquals(2, taskHistoryResourceList.size()); | ||
| assertEquals("COMPLETED", taskHistoryResourceList.get(1).getState()); | ||
| assertNotNull(taskHistoryResourceList.get(1).getAssignee()); |
There was a problem hiding this comment.
Majority of assertNotNull assertions can use real values
| }); | ||
|
|
||
| await() | ||
| .pollDelay(5, SECONDS) |
There was a problem hiding this comment.
Do we need to wait 5 seconds between each poll?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RWA-4661
Change description
Does this PR introduce a breaking change? (check one with "x")