Skip to content

Conversation

dflemstr
Copy link

@dflemstr dflemstr commented Jun 8, 2021

The alga crate is deprecated and has been replaced by simba. This PR also allows the introduction of a much newer nalgebra version which is pretty significant.

Depends on hmeyer/bbox#3 for now, after which the [patch] section will be removed

Copy link
Owner

@hmeyer hmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please also bump the minor version of this package to 0.15.

stl_io = "0.5"
bbox = "0.11"
num-traits = "0.2"
bbox = "0.11.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't just major+minor be fine?

Copy link
Author

@dflemstr dflemstr Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the default conventions of the cargo-edit tool which was what I used to automate this change. I suppose it might help ensure that users of this crate get at least the version of a dependency that was used to run the test suite. Imagine if 0.5.2 is buggy, 0.5.3 is fine, and the tests of this crate were tested against 0.5.3. Setting the patch version ensures that users don't accidentally get the 0.5.2 version (ie. they get at least the version that this crate was tested against).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmeyer
Copy link
Owner

hmeyer commented Jun 14, 2021

Build currently fails with this PR. Can you please take a look?

@dflemstr
Copy link
Author

Hey! I'll work on fixing the PR! It would help a little bit if the new bbox version was released to crates.io so I can get this PR ready in one go

@dflemstr
Copy link
Author

The issue is that the normal bbox dependency is set to 0.11 but my patched repo version contains version 0.12 (since you asked me to bump to that version as part of the PR), which means that cargo considers the patch to be incompatible with the normal dependency.

The fix is to remove the patch and select bbox = "0.12.0" and this PR will start succeeding. But, that requires the bbox dependency on version 0.12.0 to be released first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants