Triangle from Vertices Constructor #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… vector and checks that vertices are valid. Uses right-hand rule cross-product for finding the normal.
hmeyer
reviewed
Mar 4, 2025
There was a problem hiding this comment.
I' m sorry - but I have to push back on this change.
stl_io is meant to manage STL file creation and reading.
The changes you are requesting here are better implemented using https://docs.rs/nalgebra/latest/nalgebra/.
|
No need for apologies! To clarify, are you saying you would rather this feature not exist in stl_io at all or that you would rather the implementation incorporated what is available through nalgebra? Either is fine, but if it is the latter, I'm happy to revise. And thank you for your response! |
|
I'd rather not have it in stl_io.
The rationale is, that I want to keep the dependencies reasonably minimal.
Hope that makes sense.
cfpbiggs ***@***.***> schrieb am Di., 4. März 2025, 22:18:
… No need for apologies! To clarify, are you saying you would rather this
feature not exist in stl_io at all or that you would rather the
implementation incorporated what is available through nalgebra? Either is
fine, but if it is the latter, I'm happy to revise. And thank you for your
response!
—
Reply to this email directly, view it on GitHub
<#25 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAE7LCSNU6L456JHSBWI6T2SYKBDAVCNFSM6AAAAABXZEOYGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJYHEZTMMJWHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: cfpbiggs]*cfpbiggs* left a comment (hmeyer/stl_io#25)
<#25 (comment)>
No need for apologies! To clarify, are you saying you would rather this
feature not exist in stl_io at all or that you would rather the
implementation incorporated what is available through nalgebra? Either is
fine, but if it is the latter, I'm happy to revise. And thank you for your
response!
—
Reply to this email directly, view it on GitHub
<#25 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAE7LCSNU6L456JHSBWI6T2SYKBDAVCNFSM6AAAAABXZEOYGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJYHEZTMMJWHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
That makes perfect sense! Does that mean issue #19 should be closed? Based on that thread, it looked like this was still a desired feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add from_vertices constructor for Triangle that calculates the normal vector and checks that vertices are valid. Uses right-hand rule cross-product for finding the normal.