-
Notifications
You must be signed in to change notification settings - Fork 5
Added clipped text and button polyfill issues #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Marat-Faizov
wants to merge
9
commits into
main
Choose a base branch
from
new-issues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
36288de
added clipped text and button polyfill issues
Marat-Faizov 7c0869e
updated link as button issue
Marat-Faizov e24a5b2
added missing statement snippets
Marat-Faizov 6507508
work on feedback
Marat-Faizov 319a442
work on feedback(missed label)
Marat-Faizov 3f2d1a5
Update link-as-button.md
shabana-ali 7bdb7b3
removed -description and updated statement for one of the issues
Marat-Faizov 8af1e2a
added two isues to read me
Marat-Faizov 5dafb13
updated link as button issue to include data-module attr
Marat-Faizov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # Issue: Text is clipped [Draft] | ||
|
|
||
| Text is present which does not wrap to stay within the bounds of its parent container when user rely on text resizing. Increasing font size causing the text to either extend beyond the container, causing the layout to break or scrollbars to appear, or the text is clipped by the parent container and content is lost. | ||
| This create difficulties for people who rely on text to be resized without loss of the content. | ||
|
|
||
|
|
||
| ## To resolve | ||
|
|
||
| Most recent govuk-frontend should containe fix for this issue panel heading | ||
| https://github.com/alphagov/govuk-frontend/pull/2347. | ||
| Or apply `.text-overflow` class on element | ||
|
|
||
| ``` | ||
| .text-overflow { | ||
| word-wrap: break-word; /* old version of overflow-wrap for IE and Edge and FF < 49*/ | ||
| overflow-wrap: anywhere; /* modern, tries to fit word on a new line rather than fitting on remnants of the current line */ | ||
| } | ||
| ``` | ||
| ## Labels | ||
|
|
||
| - wcag | ||
| - wcag 1.4.4 (AA) | ||
| - large text | ||
|
|
||
| ## Report | ||
|
|
||
| | Status | Level | Issue | Success Criterion | | ||
| | ------ | ----- | ----- | ----------------- | | ||
| | 🟠 (M) | AA | [#issue]():Text is clipped | 1.4.4 Resize text | | ||
|
|
||
| ## Statement | ||
|
|
||
| ### Accessibility problems | ||
| ``` | ||
| - description: When text is resized [named] text is cut off and so may not display the entire information intended. | ||
| ``` | ||
|
|
||
| ### Milestones | ||
|
|
||
| ``` | ||
| - description: When text is resized, content is lost. This fails WCAG 2.1 success criterion 1.4.4 Resize text | ||
| date: TBC | ||
|
|
||
| ``` | ||
|
|
||
| ## References | ||
|
|
||
| [govuk-font mixin - GOV.UK Frontend](https://frontend.design-system.service.gov.uk/sass-api-reference/#govuk-typography-responsive-usage) | ||
|
|
||
| [Understanding Success Criterion 1.4.4 Resize text ](https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-scale.html) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Issue: Link styled as a button [Draft] | ||
|
|
||
| For a link styled as a button, add `role="button"` and initialise the JavaScript polyfill to ensure it acts as a button. | ||
|
|
||
| - Adding ARIA `role="button"` will identify the link as a button to assistive technologies. | ||
| - The JavaScript polyfill makes sure that the link responds to the <kbd>enter</kbd> and <kbd>spacebar</kbd> keypress. | ||
|
|
||
| ## To resolve | ||
|
|
||
| Follow guidance [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons). | ||
|
|
||
| ## Labels | ||
| - wcag | ||
| - wcag 4.1.2 (A) | ||
| - button | ||
| - code quality | ||
| - keyboard-only | ||
|
|
||
| ## Report | ||
|
|
||
| | Status | Level | Issue | Success Criterion | | ||
| | ------ | ----- | ----- | ----------------- | | ||
| | 🔴 (H) | A | [#issue](): Link styled as a button | 4.1.2 Name, Role, Value | | ||
|
|
||
| ## Statement | ||
|
|
||
| ### Accessibility problems | ||
| ``` | ||
| on the [page title] page, the [link text] link has been styled as a button, but is not seen as one with assistive technologies and does not work with the spacebar keypress | ||
| ``` | ||
|
|
||
| ### Milestones | ||
| ``` | ||
| for a link styled as a button, the role="button" and the JavaScript polyfill is missing to ensure it acts like a button. This fails WCAG 2.1 success criterion 4.1.2: Name, Role, Value | ||
| ``` | ||
|
|
||
| ## References | ||
|
|
||
| [Using links as buttons](https://github.com/hmrc/accessibility/blob/master/docs/design-and-usability-quick-wins.md#using-links-as-buttons) | ||
|
|
||
| [Understanding Success Criterion 4.1.2 Name, Role, Value](https://www.w3.org/WAI/WCAG21/Understanding/name-role-value) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added