Create low-level REST client #15
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siku2
force-pushed
the
feat/rest
branch
2 times, most recently
from
addcba0 to
88a8c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows: #14
This PR creates the low-level
dingz.restmodule which aims to provide a thin abstraction over the dingz REST API.The goal is to rebuild the high-level API on top of this layer.
The current vision is to have:
dingz.rest- handles the REST APIdingz.webhook- infrastructure for receiving "webhook" pushes from the dingz devicesdingz.mqtt- handles the MQTT APIdingz- High level API, similar to the current API. This API can make use of all three interfaces to allow for real-time updates.I want to support both webhook and mqtt. Webhooks are easy to set up automatically, but MQTT scales a lot better.
While working on these changes I realized that the current state of the codebase is completely unusable with the newer dingz firmware. I decided that I won't even try to keep things backwards-compatible. Naturally, this is gonna lead to a lot of breaking changes.