Prowl migrate yaml configflow #154727
Prowl migrate yaml configflow #154727
Conversation
…ed to separate exceptions rather than string comparisons
home-assistant
bot
added
cla-signed
deprecation
| "issues": { | ||
| "prowl_yaml_deprecated": { | ||
| "title": "Prowl YAML configuration deprecated", | ||
| "description": "Configuring Prowl using YAML has been deprecated. An automatic import of your existing configuration has been made.\nPlease remove the Prowl configuration from configuration.yaml and update any automations to use the new `notify.send_message` action exposed with this new entity." |
There was a problem hiding this comment.
nd update any automations to use the new
notify.send_messageaction exposed with this new entity.
Uh that sounds like a major breaking change or something that should be been raise repairs for separately; and not something that should be squeezed into this message.
There was a problem hiding this comment.
Yes, we do that too. https://github.com/home-assistant/core/pull/154727/files#diff-16a6406edebe12b764d2e6c7ccc098fdb11b4c7bcfcf1ab6edc46ce9f416f7ecR81 I just added it here to reinforce that there are more actions other than just migrating the YAML.
Should I perhaps phrase it better?
| hass: HomeAssistant, issue_registry: ir.IssueRegistry | ||
| ) -> None: | ||
| """Test that YAML configuration triggers config entry creation.""" | ||
| entry = get_config_entry(hass, TEST_API_KEY, config_method="import") |
There was a problem hiding this comment.
Instead of making a lookup, we can also just let the configure_prowl_through_yaml fixture return the config entry.
../Frenck
There was a problem hiding this comment.
Is there a method of getting the ConfigEntry after running async_setup_component that is different from doing essentially for entry in hass.config_entries.async_entries(DOMAIN):? (or maybe you just suggested to move it to the fixture to avoid the helper function?)
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
2 participants
Breaking change
Deprecating the legacy YAML configuration and adding automatic migration to ConfigEntry for the Prowl notification service.
Proposed change
Helping users migrate Prowl to the new ConfigFlow setup in preparation for deprecating the legacy YAML configuration and the legacy notification method.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: