Skip to content

Region per file storage strategy #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Region per file storage strategy #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
844ae19
checkpoint
TheAssembler1 Sep 17, 2025
a391dc3
Committing clang-format changes
github-actions[bot] Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/server/pdc_server_region/include/pdc_server_region_transfer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,29 @@

#include "pdc_region.h"

typedef enum pdc_region_writeout_strategy {
/**
* Store data as multiple regions inside a single file.
* Overlapping writes that are not fully contained append new regions
* to the end of the file, with metadata tracking region locations.
* Supports incremental updates without rewriting large parts of the file.
*/
STORE_REGION_BY_REGION_SINGLE_FILE = 0,

/**
* Store the entire object as a single flat file.
* Reads and writes operate by seeking directly within the file.
* No region metadata bookkeeping; simpler but less flexible for partial updates.
*/
STORE_FLATTENED_SINGLE_FILE,

/**
* Store each flattened region in its own separate file.
* Enables independent file management per region.
*/
STORE_FLATTENED_REGION_PER_FILE
} pdc_region_writeout_strategy;

typedef struct transfer_request_all_data {
uint64_t **obj_dims;
uint64_t **remote_offset;
Expand Down
5 changes: 0 additions & 5 deletions src/server/pdc_server_region/pdc_server_data.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4059,11 +4059,6 @@ PDC_Server_data_write_out(uint64_t obj_id, struct pdc_region_info *region_info,
uint64_t i, j, pos;
uint64_t * overlap_offset, *overlap_size;
char * tmp_buf;
#if 0
size_t total_write_size = 0, local_write_size;
int is_overlap;
#endif
FUNC_ENTER(NULL);
#ifdef PDC_TIMING
double start = MPI_Wtime(), start_posix;
#endif
Expand Down
13 changes: 0 additions & 13 deletions src/server/pdc_server_region/pdc_server_region_request_handler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,6 @@ transfer_request_all_bulk_transfer_write_cb(const struct hg_cb_info *info)
request_data.obj_dims[i], remote_reg_info,
(void *)request_data.data_buf[i], request_data.unit[i], 1);
#endif

#if 0
uint64_t j;
LOG_ERROR("server write array, offset = %lu, size = %lu:", request_data.remote_offset[i][0], request_data.remote_length[i][0]);
for ( j = 0; j < remote_reg_info->size[0]; ++j ) {
LOG_ERROR("%d,", *(int*)(request_data.data_buf[i] + sizeof(int) * j));
}
LOG_ERROR("\n");
#endif
pthread_mutex_lock(&transfer_request_status_mutex);
PDC_finish_request(local_bulk_args->transfer_request_id[i]);
pthread_mutex_unlock(&transfer_request_status_mutex);
Expand Down Expand Up @@ -345,10 +336,6 @@ transfer_request_bulk_transfer_write_cb(const struct hg_cb_info *info)
remote_reg_info->ndim, remote_reg_info->ndim);
PDC_copy_region_desc((local_bulk_args->in).obj_dims, obj_dims, remote_reg_info->ndim,
remote_reg_info->ndim);
/*
printf("Server transfer request at write branch, index 1 value = %d\n",
*((int *)(local_bulk_args->data_buf + sizeof(int))));
*/
#ifdef PDC_SERVER_CACHE
PDC_transfer_request_data_write_out(local_bulk_args->in.obj_id, local_bulk_args->in.obj_ndim, obj_dims,
remote_reg_info, (void *)local_bulk_args->data_buf,
Expand Down
Loading