Bumped OpenFHE version to 1.4.0 #97
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloede
reviewed
Nov 5, 2025
Project.toml
Outdated
| uuid = "77ce9b8e-ecf5-45d1-bd8a-d31f384f2f95" | ||
| authors = ["Michael Schlottke-Lakemper <[email protected]>"] | ||
| version = "0.1.14-dev" | ||
| version = "0.1.15-dev" |
Member
There was a problem hiding this comment.
No. The -dev version is already incremented over the last release, such that it is clear that it is newer. If you already know that this is going to be a release once merged, you can do the following instead:
Suggested change
| version = "0.1.15-dev" | |
| version = "0.1.14" |
This reverts commit d25ddb2.
Member
|
Seems like all the int128 tests fail. Dunno if this could be related to the half-updated build in Yggdrasil, but intuitively I'd say it is probably a different issue. |
Member
|
Maybe try to run the tests locally on a Linux system to see if you can reproduce them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.