Support requiring requests to go to the configured base URL's origin #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `Config::set_mandatory_base_origin()` to enable this behavior. Useful if the `Config` includes authentication headers or similar.
|
Should this be a cargo option? Or do you think it's better on |
|
@Fishrock123 I definitely don't think it should be a cargo feature; that'd be backwards-incompatible for anyone not expecting that behavior, including other users elsewhere in the dependency tree that didn't set that feature. I think it makes sense to set this on a config-by-config basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Config::set_mandatory_base_origin()to enable this behavior.Useful if the
Configincludes authentication headers or similar.