Skip to content

Conversation

@ixti
Copy link
Member

@ixti ixti commented Aug 28, 2024

No description provided.

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

@tarcieri if that looks good to you - I will cut the release

@ixti ixti requested a review from tarcieri August 28, 2024 15:24
@tarcieri
Copy link
Member

Are there actually any breaking changes?

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

I believe #776 and #783 are.

Also, I just noticed a PR that I wanted to merge 4 years ago and never get to it, that I believe we should add in the release. The change will be in how readpartial work to make it more IO-alike (raising EOFError when the end is reached instead of silent empty chunk). See: #618

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

Alternative - I can cherry pick retriable and headers caching and cut 5.3.0 release instead.

@tarcieri
Copy link
Member

I’d definitely like to roll forward rather than backward, but v6.0.0 would be a great time to update the timeout subsystem: #773

@ixti
Copy link
Member Author

ixti commented Aug 28, 2024

Will merge #773

@tarcieri
Copy link
Member

#773 is an issue, not a PR. Perhaps we should ping the people mentioned in that issue to see if they can open a PR, though

@ixti
Copy link
Member Author

ixti commented Aug 29, 2024

Oh, I have confused it with #754 indeed

@tarcieri
Copy link
Member

tarcieri commented Sep 5, 2024

I made a last call for breaking changes to the timeout subsystem in #773, though perhaps we should merge #754 first as well

@lineofflightagent
Copy link

Hey @ixti! 👋

I maintain the Peddler gem (Amazon SP-API client) and we'd love to use the :raise_error feature from #792 for our error handling. It's exactly what we need!

Since v6.0.0 seems blocked on breaking changes, would you consider that v5.3.0 release you mentioned in August? Cherry-picking the raise_error feature (plus retriable/headers caching) would help us and other downstream libraries adopt it immediately rather than waiting for v6.0.0.

Thanks for all the great work on HTTP! 🙏

@ixti
Copy link
Member Author

ixti commented Jun 9, 2025

After looking through the changes, I think it's fine to release 5.3.0 off the master by only excluding 1ba37c2, the rest looks fine for minor version bump. Doing that now

@ixti
Copy link
Member Author

ixti commented Jun 9, 2025

Released v5.3.0; Closing this ticket, as I agree we should add as many breaking changes as we can to avoid making major bumps a habbit ;D

@ixti ixti closed this Jun 9, 2025
@ixti
Copy link
Member Author

ixti commented Jun 9, 2025

Here's the list of backported commits: v5.2.0...v5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants