Skip to content

Conversation

@bismuthdev
Copy link

@bismuthdev bismuthdev bot commented Apr 17, 2025

Overview

This pull request addresses a critical issue with the OpenTelemetry integration shutdown process in the main application.

Changes

  • Added a centralized Shutdown function in the OpenTelemetry integration to properly close tracer and meter providers
  • Modified the main function to use the new shutdown mechanism
  • Improved error handling during OpenTelemetry provider shutdown

Motivation

The previous implementation lacked a robust shutdown mechanism, which could potentially lead to:

  • Data loss
  • Incomplete telemetry data transmission
  • Resource leaks

Details

  • Updated acp/cmd/main.go to use a centralized shutdown method
  • Ensures graceful termination of OpenTelemetry providers
  • Adds error logging for shutdown failures

Impact

  • Improves reliability of telemetry data collection
  • Prevents potential resource leaks
  • Provides better error handling during application shutdown

Fixes: OpenTelemetry Integration Shutdown Issue

…close tracer and meter providers when the application terminates. The current implementation in acp/internal/otel/otel.go lacks a graceful shutdown mechanism, which could lead to data loss or incomplete telemetry data being sent.
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ allisoneer
❌ bismuthdev[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@allisoneer
Copy link
Contributor

I like this, seems useful and reasonable

@allisoneer
Copy link
Contributor

Fixed up linting then will approve/merge if ci is happy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants