feat(deps): toolchain upgrades, RN output updates #342

bryce-mcmath · 2025-09-25T07:03:04Z

Main point of this is modernizing to support React Native New Architecture and Android 16kb memory page size requirement.

Upgraded rust and c tool chain
Upgraded Node
Upgraded yarn
Upgraded React / React Native
Upgraded gradle
Updated Docker images
Updated CI macOS version
Updated broken test scripts
Added TurboModule support for new architecture
Updated min iOS and macOS deployment targets
Replaced node-pre-gyp with custom scripts matching askar-wrapper-javascript

Signed-off-by: Bryce McMath <[email protected]>

swcurran · 2025-09-25T14:39:18Z

@bryce-mcmath -- recent work in the Askar Wrapper might help with the failing tests.

FYI @TimoGlastra @genaris @andrewwhitehead @berendsliedrecht on this PR.

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath · 2025-09-26T05:11:01Z

.cargo/config.toml

@@ -0,0 +1,20 @@
+[env]
+CMAKE_POLICY_VERSION_MINIMUM = "3.30"


To avoid current CICD from breaking due to unsupported CMake version

This is not in Askar/anoncreds, right? Is there a reason why it breaks here, but not there?

zmq-related, which I don't believe askar or anoncreds use, so they likely don't need this

bryce-mcmath · 2025-09-26T05:11:30Z

.cargo/config.toml

+[target.aarch64-linux-android]
+rustflags = ["-C", "link-arg=-Wl,-z,max-page-size=16384"]
+
+[target.armv7-linux-androideabi]
+rustflags = ["-C", "link-arg=-Wl,-z,max-page-size=16384"]
+
+[target.i686-linux-android]
+rustflags = ["-C", "link-arg=-Wl,-z,max-page-size=16384"]
+
+[target.x86_64-linux-android]
+rustflags = ["-C", "link-arg=-Wl,-z,max-page-size=16384"]


Ensuring the 16kb memory page size requirement is satisfied

.cargo/config.toml

bryce-mcmath · 2025-09-26T05:13:06Z

.github/workflows/build.yml


 env:
-  RUST_VERSION: "1.81.0"
+  RUST_VERSION: "1.85.0"


1.82 is the oldest supported, 1.90 is the latest, this is a happy medium with no breaking changes

bryce-mcmath · 2025-09-26T05:14:10Z

.github/workflows/build.yml

    strategy:
      matrix:
-        os: [macos-13, windows-latest, ubuntu-latest]
+        os: [macos-14, windows-latest, ubuntu-latest]


Matching Bifold and other Credo-based mobile apps CICD MacOS version

bryce-mcmath · 2025-09-26T05:14:41Z

.github/workflows/build.yml

        with:
          shared-key: deps
          cache-on-failure: true
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.toml') }}


Prevent stale cache if deps change

bryce-mcmath · 2025-09-26T05:18:17Z

libindy_vdr/Cargo.toml

-# This is added so we can lock the version that zmq uses
-# 0.1.49 is broken for ios targets
-cmake = { version = "=0.1.48", optional = true }


iOS issue was fixed in 0.1.50

bryce-mcmath · 2025-09-26T05:26:25Z

wrappers/javascript/indy-vdr-react-native/android/CMakeLists.txt

+if(${REACT_NATIVE_VERSION} GREATER_EQUAL 76)
+  target_link_libraries(
+    ${PACKAGE_NAME}
+    ReactAndroid::jsi
+    ReactAndroid::reactnative
+    fbjni::fbjni
+  )
+elseif(${REACT_NATIVE_VERSION} GREATER_EQUAL 71)


in 76 and up, reactnativejni is not included

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath · 2025-09-26T06:44:01Z

wrappers/python/indy_vdr/utils.py


 INDY_NETWORKS_GITHUB_RAW_BASE = (
-    "https://raw.githubusercontent.com/hyperledger/indy-did-networks/main"
+    "https://raw.githubusercontent.com/hyperledger/indy-node-monitor/main/fetch-validator-status/networks.json"


Previous URL no longer resolves so these tests were failing

wrappers/javascript/indy-vdr-react-native/tsconfig.build.json

libindy_vdr/src/pool/networker/zmq.rs

wrappers/javascript/indy-vdr-react-native/android/build.gradle

Signed-off-by: Bryce McMath <[email protected]>

.cargo/config.toml

Signed-off-by: Bryce McMath <[email protected]>

wrappers/javascript/indy-vdr-react-native/package.json

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath · 2025-10-06T20:39:13Z

.cargo/config.toml

+MACOSX_DEPLOYMENT_TARGET = "14.0"
+IPHONEOS_DEPLOYMENT_TARGET = "15.1"
+CMAKE_OSX_DEPLOYMENT_TARGET = "15.1"


@berendsliedrecht I think this is a slightly cleaner fix for setting the deployment targets, let me know what you think

Yes, I think this is good :).

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath · 2025-10-06T21:30:55Z

@TimoGlastra @berendsliedrecht @genaris @andrewwhitehead ready for review when you have time, thanks for all the suggestions so far

TimoGlastra · 2025-10-09T13:43:15Z

@bryce-mcmath can you verify that the changes from this branch are also covered in this PR to main: main...js-0.4.1

This branch is the version that Credo currently depends on. I see there's at least one fix in .cpp file

berendsliedrecht · 2025-10-09T15:11:50Z

I'll add my review tomorrow!

bryce-mcmath · 2025-10-09T18:45:40Z

@bryce-mcmath can you verify that the changes from this branch are also covered in this PR to main: main...js-0.4.1

This branch is the version that Credo currently depends on. I see there's at least one fix in .cpp file

ah I was unaware of this! I will back port those changes into this PR

TimoGlastra · 2025-10-09T18:48:14Z

Thanks! it's a bit of a mess TBH so appreciate you cleaning up and fixing everything :)

Signed-off-by: Bryce McMath <[email protected]>

berendsliedrecht

Thanks for the work!!

For maintenance in the future, it might also be good to split the wrappers into a new repo and move the js wrapper more to be consistent with askar/anoncreds (biomejs/node (or vite) test/pnpm). We sadly do not have the time for this anymore, but would be willing to help with this and give some pointers.

berendsliedrecht · 2025-10-10T09:40:28Z

.cargo/config.toml

+MACOSX_DEPLOYMENT_TARGET = "14.0"
+IPHONEOS_DEPLOYMENT_TARGET = "15.1"
+CMAKE_OSX_DEPLOYMENT_TARGET = "15.1"


Yes, I think this is good :).

berendsliedrecht · 2025-10-10T09:42:29Z

docker/Dockerfile.test-python


-ADD libindy_vdr .
+COPY . .
+RUN rustup show


Is this still needed?

No, was just using that for troubleshooting. Will remove

berendsliedrecht · 2025-10-10T09:45:24Z

wrappers/javascript/indy-vdr-react-native/package.json

+    "host": "https://github.com/hyperledger/indy-vdr/releases/download",
+    "packageName": "library-ios-android.tar.gz"
+  },
+  "codegenConfig": {


Is this codegen now fully working? I was expecting more changed in the C++ side. If this was just to test, it might be good to remove it again and look at it in a different PR as a single new feature.

Oh good point, let me double check this. I'll move it back to draft for now and will re-request your review once I make any necessary changes

feat(deps): toolchain upgrades, RN output updates

ce1b8a1

Signed-off-by: Bryce McMath <[email protected]>

fix: macos min deployment target

3ea9116

Signed-off-by: Bryce McMath <[email protected]>

feat(deps): configurable ports and fix for cc

be4b2a4

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath commented Sep 26, 2025

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

bryce-mcmath commented Sep 26, 2025

View reviewed changes

fix: run fmt

5e82495

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath commented Sep 26, 2025

View reviewed changes

wrappers/javascript/indy-vdr-react-native/tsconfig.build.json Show resolved Hide resolved

bryce-mcmath commented Sep 26, 2025

View reviewed changes

libindy_vdr/src/pool/networker/zmq.rs Outdated Show resolved Hide resolved

genaris reviewed Oct 2, 2025

View reviewed changes

wrappers/javascript/indy-vdr-react-native/android/build.gradle Show resolved Hide resolved

bryce-mcmath added 2 commits October 2, 2025 13:27

fix(deps): ios builds and upgrade gradle

0ecb436

Signed-off-by: Bryce McMath <[email protected]>

fix(deps): yarn issue and remove port restriction logic

712209b

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath commented Oct 2, 2025

View reviewed changes

.cargo/config.toml Outdated Show resolved Hide resolved

fix: specify yarn version in gha

616ac8f

Signed-off-by: Bryce McMath <[email protected]>

TimoGlastra reviewed Oct 6, 2025

View reviewed changes

wrappers/javascript/indy-vdr-react-native/package.json Outdated Show resolved Hide resolved

refactor: install scripts and env settings

a2d2915

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath commented Oct 6, 2025

View reviewed changes

fix: lint

e7e36d6

Signed-off-by: Bryce McMath <[email protected]>

bryce-mcmath marked this pull request as ready for review October 6, 2025 21:29

bryce-mcmath requested review from TimoGlastra, berendsliedrecht and genaris October 7, 2025 16:02

genaris approved these changes Oct 7, 2025

View reviewed changes

berendsliedrecht mentioned this pull request Oct 8, 2025

indy-vdr-react-native won't build for RN > 0.73.11 #344

Closed

bryce-mcmath added 3 commits October 9, 2025 19:01

fix: backport 0.4.1 changes

c616959

Signed-off-by: Bryce McMath <[email protected]>

chore: lint

9496aa4

Signed-off-by: Bryce McMath <[email protected]>

chore: format

875af23

Signed-off-by: Bryce McMath <[email protected]>

berendsliedrecht approved these changes Oct 10, 2025

View reviewed changes

bryce-mcmath marked this pull request as draft October 14, 2025 20:45

feat(deps): toolchain upgrades, RN output updates #342

Are you sure you want to change the base?

feat(deps): toolchain upgrades, RN output updates #342

Uh oh!

Conversation

bryce-mcmath commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swcurran commented Sep 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bryce-mcmath commented Oct 6, 2025

Uh oh!

TimoGlastra commented Oct 9, 2025

Uh oh!

berendsliedrecht commented Oct 9, 2025

Uh oh!

bryce-mcmath commented Oct 9, 2025

Uh oh!

TimoGlastra commented Oct 9, 2025

Uh oh!

berendsliedrecht left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bryce-mcmath commented Sep 25, 2025 •

edited

Loading