-
Notifications
You must be signed in to change notification settings - Fork 0
Complete missing proxy modules in src/algorithms #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add missing sorting algorithms (heap_sort, merge_sort, quick_sort) to src/algorithms/sorting/ Create new src/algorithms/searching/ directory with all searching algorithms Update __all__ lists to include all available algorithms Co-authored-by: ianlintner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds proxy modules for three sorting algorithms (heap_sort, merge_sort, quick_sort) and four searching algorithms (advanced_search, binary_search, linear_search, quickselect) to enable imports from src.algorithms.sorting.* and src.algorithms.searching.*. It also creates a new __init__.py for the searching namespace with lazy loading and updates the sorting __init__.py to include the new algorithms in __all__ and documentation.
- Adds proxy modules for heap_sort, merge_sort, and quick_sort in src/algorithms/sorting/
- Adds proxy modules for advanced_search, binary_search, linear_search, and quickselect in src/algorithms/searching/
- Creates lazy loading infrastructure for src/algorithms/searching/init.py
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/algorithms/sorting/quick_sort.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/sorting/merge_sort.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/sorting/heap_sort.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/sorting/init.py | Updated all list and docstring to include heap_sort, merge_sort, and quick_sort |
| src/algorithms/searching/quickselect.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/searching/linear_search.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/searching/binary_search.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/searching/advanced_search.py | Proxy module redirecting to interview_workbook implementation |
| src/algorithms/searching/init.py | New lazy loading namespace for searching algorithms with getattr implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot The tests are failing on PR |
The
src/algorithms/proxy layer was incomplete—missing sorting algorithms and the entire searching directory, despite implementations existing ininterview_workbook/.Changes
src/algorithms/sorting/
heap_sort,merge_sort,quick_sortto__all__and created corresponding proxy modulessrc/algorithms/searching/ (new)
__init__.pyusing lazy loading patternadvanced_search,binary_search,linear_search,quickselectUsage
All proxy modules follow the established pattern with wildcard imports from
interview_workbook.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.