IBX-10611: RadioButton Field #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new RadioButton field component for the Ibexa design system by creating a radio button input component and its corresponding field wrapper. The implementation follows the established pattern used for other choice inputs like checkboxes.
- Creates a new
RadioButtoninput component with required value property - Adds a
RadioButtonFieldform control component with label support - Refactors existing choice input components to use a shared base template for consistency
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| RadioButton.php | New radio button input component with value property and type method |
| RadioButtonField.php | New form control wrapper that extends RadioButton with labeling capabilities |
| LabelledChoiceInputTrait.php | New trait providing common labeling functionality for choice input fields |
| AbstractChoiceInput.php | Enhanced base class with name, size, inputClass properties and abstract getType method |
| ThreeStateCheckbox.php, Checkbox.php | Updated to implement getType method and add ExposeInTemplate import |
| Template files | Refactored to use shared base templates and consistent component structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| #[AsTwigComponent('ibexa:inputs:radio_button')] | ||
| final class RadioButton extends AbstractChoiceInput | ||
| class RadioButton extends AbstractChoiceInput |
There was a problem hiding this comment.
The RadioButton class should be declared as final to maintain consistency with other input components like Checkbox and ThreeStateCheckbox.
Suggested change
| class RadioButton extends AbstractChoiceInput | |
| final class RadioButton extends AbstractChoiceInput |
Copilot uses AI. Check for mistakes.
tischsoic
approved these changes
Sep 9, 2025
GrabowskiM
force-pushed
the
IBX-10611
branch
from
3469206 to
c1ead5a
Compare
albozek
approved these changes
Sep 15, 2025
dew326
approved these changes
Sep 18, 2025
GrabowskiM
force-pushed
the
IBX-10611
branch
from
c1ead5a to
0a304d5
Compare
GrabowskiM
force-pushed
the
IBX-10611
branch
from
0a304d5 to
e8f361e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
direct iframe src:
For QA:
Documentation: