Skip to content

Conversation

phcoder
Copy link

@phcoder phcoder commented Feb 27, 2025

This PR fixes boot problems on darp10-b

Dboot is 32-bit, so uintptr_t is uint32_t, so despite
config entries on efi64 as well as nativeptr_t being
both 64-bit we end up truncating addresses. This patch
fixes booting on darp10-b

Signed-off-by: Vladimir Serbinenko <[email protected]>
Dboot is 32-bit, so if vendor name is above 4GiB mark it's
difficult to read it. Just skip it instead of attempting to read
random garbage

Signed-off-by: Vladimir Serbinenko <[email protected]>
@tsoome
Copy link
Contributor

tsoome commented Feb 27, 2025

Hi!

We do not accept pull requests, but if you could mail me ([email protected]) the git format-patch output, can run the integration process for you.

@JunielKatarn
Copy link

Hi!

We do not accept pull requests, but if you could mail me ([email protected]) the git format-patch output, can run the integration process for you.

I am curious about this.

What's wrong with pull requests?

@Bill-Sommerfeld
Copy link
Contributor

What's wrong with pull requests?

The fact that we don't accept pull requests isn't a statement that there's anything "wrong" with pull requests.

We use a different process with illumos-gate. See https://illumos.org/docs/contributing/. There are other illumos repos which do accept pull requests.

Note that this is hardly unique - there are other significant projects which have a read-only mirror on github but don't accept contributions through pull requests. Unfortunately github makes it difficult to turn off pull-request creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants