[WIP] improve covr tests [WIP] #1646

m7pr · 2025-11-06T12:11:26Z

Part of #1600

module_snapshot_manager + friends

Signed-off-by: Marcin <[email protected]>

m7pr · 2025-11-06T12:47:10Z

Hey, changing to regular PR to start tests, because they dont work for me locally

github-actions · 2025-11-06T12:59:33Z

Unit Tests Summary

1 files 29 suites 2m 31s ⏱️
379 tests 329 ✅ 50 💤 0 ❌
614 runs 560 ✅ 54 💤 0 ❌

Results for commit 9e674a7.

♻️ This comment has been updated with latest results.

github-actions · 2025-11-06T12:59:36Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
module_session_info	💚	$18.05$	$-1.07$	$0$	$0$	$0$	$0$
module_teal_data	👶		$+0.70$	$+6$	$0$	$0$	$0$
reporter_previewer_module	👶		$+0.07$	$+15$	$0$	$0$	$0$
shinytest2-disable_report	💀	$0.39$	$-0.39$	$-4$	$-4$	$0$	$0$
shinytest2-disable_src	💀	$0.19$	$-0.19$	$-2$	$-2$	$0$	$0$
shinytest2-show-rcode	💀	$0.28$	$-0.28$	$-3$	$-3$	$0$	$0$
shinytest2-teal_modifiers	💀	$0.53$	$-0.53$	$-7$	$-7$	$0$	$0$
validations	👶		$+0.16$	$+28$	$0$	$0$	$0$
zzz	👶		$+0.05$	$+18$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
module_session_info	💚	$18.03$	$-1.07$	creation_process_is_invoked_for_teal.lockfile.mode_enabled_and_snapshot_is_copied_to_teal_app.lock_and_removed_after_session_ended
module_teal	👶		$+0.40$	adds_snapshot_to_history_when_name_is_provided
module_teal	👶		$+0.36$	appends_multiple_snapshots_to_the_history_
module_teal	👶		$+0.46$	appends_uploaded_snapshot_to_the_snapshot_list_with_the_name_from_file_when_input_is_
module_teal	👶		$+0.46$	appends_uploaded_snapshot_to_the_snapshot_list_with_the_name_from_input
module_teal	👶		$+0.27$	clicking_show_filter_manager_opens_modal_containing_filter_manager_uiOutput
module_teal	👶		$+0.31$	doesn_t_add_when_duplicated_snapshot_name
module_teal	👶		$+0.26$	doesn_t_add_when_snapshot_name_is_empty
module_teal	👶		$+0.32$	doesn_t_append_uploaded_snapshot_to_the_snapshot_list_when_name_already_exists
module_teal	👶		$+0.30$	doesn_t_append_uploaded_snapshot_to_the_snapshot_list_when_teal_slices_have_different_app_id
module_teal	👶		$+0.27$	enables_accept_button_when_file_is_selected
module_teal	👶		$+1.22$	mapping_table_returns_column_per_module_with_active_true_inactive_false_unavailable_na
module_teal	👶		$+1.20$	mapping_table_returns_global_filters_with_active_true_inactive_false_unavailable_na
module_teal	👶		$+1.36$	mapping_table_returns_no_rows_if_no_filters_set
module_teal	👶		$+0.03$	mapping_table_what_happens_when_module_label_is_duplicated_when_nested_modules_
module_teal	👶		$+0.68$	modules_with_input_output_session_are_supoorted
module_teal	👶		$+0.20$	opens_modal_with_a_specific_id_when_open_teal_data_module_ui_is_clicked
module_teal	👶		$+0.20$	opens_snapshot_manager_modal_when_show_button_is_clicked
module_teal	👶		$+0.08$	restores_snapshot_history_from_bookmarked_values
module_teal	👶		$+0.49$	restores_specific_snapshot_when_select_button_is_clicked
module_teal	💀	$1.29$	$-1.29$	returns_column_per_module_with_active_true_inactive_false_unavailable_na
module_teal	💀	$1.22$	$-1.22$	returns_global_filters_with_active_true_inactive_false_unavailable_na
module_teal	💀	$1.01$	$-1.01$	returns_no_rows_if_no_filters_set
module_teal	👶		$+0.22$	shows_upload_modal_when_upload_button_is_clicked
module_teal	👶		$+0.09$	snapshot_history_contains_initial_snapshot_on_init
module_teal	👶		$+0.18$	snapshot_list_contains_Snapshots_will_appear_here_on_init_
module_teal	👶		$+0.31$	stores_snapshot_history_in_bookmark_state_as_a_list_of_teal_slices
module_teal	👶		$+0.72$	teal_reporter_reporter_cards_are_added_to_the_bookmarks_when_doBookmark
module_teal	👶		$+0.29$	teal_reporter_reporter_cards_are_restored_from_the_bookmarks
module_teal	👶		$+0.28$	trims_whitespace_from_snapshot_name
module_teal	💀	$0.03$	$-0.03$	what_happens_when_module_label_is_duplicated_when_nested_modules_
module_teal_data	👶		$+0.15$	srv_teal_data_module_handles_error_in_data_module_via_srv_teal
module_teal_data	👶		$+0.19$	srv_teal_data_module_handles_valid_teal_data_via_srv_teal
module_teal_data	👶		$+0.15$	srv_validate_reactive_teal_data_handles_qenv.error_via_srv_teal
module_teal_data	👶		$+0.12$	srv_validate_reactive_teal_data_handles_shiny.error_via_srv_teal
module_teal_data	👶		$+0.08$	ui_teal_data_module_returns_tagList_with_wrapper_and_validation_UI_via_init
reporter_previewer_module	👶		$+0.01$	accepts_valid_server_args
reporter_previewer_module	👶		$+0.01$	creates_module_with_server_and_ui_functions
reporter_previewer_module	👶		$+0.00$	processes_multiple_server_args
reporter_previewer_module	👶		$+0.02$	returns_teal_module_with_previewer_class
reporter_previewer_module	👶		$+0.00$	stores_server_args
reporter_previewer_module	👶		$+0.01$	throws_error_when_label_is_not_a_string
reporter_previewer_module	👶		$+0.01$	throws_error_when_server_args_has_invalid_names
reporter_previewer_module	👶		$+0.01$	throws_error_when_server_args_is_not_a_named_list
reporter_previewer_module	👶		$+0.01$	uses_default_label
shinytest2-decorators	👶		$+0.03$	unnamed
shinytest2-disable_report	💀	$0.11$	$-0.11$	Add_to_report_button_is_not_disabled_by_default.
shinytest2-disable_report	💀	$0.09$	$-0.09$	Report_button_is_active_on_a_nested_module_by_default
shinytest2-disable_report	💀	$0.09$	$-0.09$	Report_button_is_disabled_on_a_module_changed_by_disable_report_
shinytest2-disable_report	💀	$0.09$	$-0.09$	Report_button_is_disabled_on_nested_modules_changed_by_disable_report_
shinytest2-disable_src	💀	$0.09$	$-0.09$	Show_R_Code_button_is_disabled_on_a_module
shinytest2-disable_src	💀	$0.10$	$-0.10$	Show_R_Code_is_disabled_on_nested_modules_changed_with_disable_src
shinytest2-reporter	👶		$+0.02$	unnamed
shinytest2-show-rcode	💀	$0.09$	$-0.09$	e2e_Module_with_Show_R_Code_has_code
shinytest2-show-rcode	💀	$0.09$	$-0.09$	e2e_Module_with_Show_R_Code_has_modal_with_two_dismiss_and_two_copy_to_clipboard_buttons
shinytest2-show-rcode	💀	$0.10$	$-0.10$	e2e_Module_with_Show_R_Code_initializes_with_visible_button
shinytest2-teal_data_module	👶		$+0.01$	unnamed
shinytest2-teal_modifiers	💀	$0.09$	$-0.09$	e2e_add_landing_modal_displays_landing_modal_on_app_startup
shinytest2-teal_modifiers	💀	$0.07$	$-0.07$	e2e_add_landing_modal_modal_can_be_dismissed
shinytest2-teal_modifiers	💀	$0.07$	$-0.07$	e2e_combined_modifiers_displays_all_customizations_when_chained_together
shinytest2-teal_modifiers	💀	$0.07$	$-0.07$	e2e_modify_footer_displays_custom_footer_in_the_app
shinytest2-teal_modifiers	💀	$0.07$	$-0.07$	e2e_modify_header_displays_custom_header_in_the_app
shinytest2-teal_modifiers	💀	$0.07$	$-0.07$	e2e_modify_title_sets_custom_title_in_the_page_title_head_title_displays_custom_favicon_in_the_app
shinytest2-teal_modifiers	💀	$0.08$	$-0.08$	e2e_modify_title_sets_custom_title_in_the_page_title_head_title_displays_custom_title_in_the_app
validations	👶		$+0.00$	validate_has_elements_passes_when_x_has_elements
validations	👶		$+0.01$	validate_has_elements_throws_error_when_x_is_empty
validations	👶		$+0.00$	validate_has_variable_passes_when_variable_exists
validations	👶		$+0.00$	validate_has_variable_passes_when_varname_is_empty
validations	👶		$+0.01$	validate_has_variable_throws_error_when_variable_is_missing
validations	👶		$+0.01$	validate_has_variable_uses_custom_message_when_provided
validations	👶		$+0.01$	validate_has_variable_works_with_multiple_variables
validations	👶		$+0.00$	validate_in_passes_when_x_is_in_choices
validations	👶		$+0.01$	validate_in_throws_error_when_choices_is_empty
validations	👶		$+0.01$	validate_in_throws_error_when_x_is_empty
validations	👶		$+0.01$	validate_in_throws_error_when_x_is_not_in_choices
validations	👶		$+0.01$	validate_in_works_with_multiple_values
validations	👶		$+0.00$	validate_n_levels_passes_when_levels_are_within_range
validations	👶		$+0.01$	validate_n_levels_throws_error_when_levels_greater_than_max_levels
validations	👶		$+0.01$	validate_n_levels_throws_error_when_levels_less_than_min_levels
validations	👶		$+0.00$	validate_n_levels_works_when_both_min_and_max_are_NULL
validations	👶		$+0.00$	validate_n_levels_works_with_non_factor_vectors
validations	👶		$+0.01$	validate_n_levels_works_with_only_max_levels
validations	👶		$+0.01$	validate_n_levels_works_with_only_min_levels
validations	👶		$+0.00$	validate_no_intersection_passes_when_x_and_y_do_not_intersect
validations	👶		$+0.01$	validate_no_intersection_throws_error_when_x_and_y_intersect
validations	👶		$+0.00$	validate_one_row_per_id_passes_when_no_duplicates_exist
validations	👶		$+0.01$	validate_one_row_per_id_throws_error_when_duplicates_exist
validations	👶		$+0.00$	validate_one_row_per_id_uses_default_key
zzz	👶		$+0.01$	.onAttach_packageStartupMessage_includes_version_number_in_message
zzz	👶		$+0.00$	.onAttach_packageStartupMessage_shows_version_message
zzz	👶		$+0.02$	.onLoad_Initialised_options_on_package_load_are_retained_and_not_overwritten
zzz	👶		$+0.02$	.onLoad_Initialised_options_on_package_load_that_are_unset_are_loaded_with_defaults

Results for commit 001c9ec

♻️ This comment has been updated with latest results.

github-actions · 2025-11-06T13:00:22Z

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ---------------------------------------------------------------------------------------
R/after.R                            59      21  64.41%   42-52, 64, 69, 77-79, 81-89, 100, 104-105
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  61       2  96.72%   44, 46
R/include_css_js.R                   11       0  100.00%
R/init.R                            152       1  99.34%   299
R/module_bookmark_manager.R          99      62  37.37%   54-58, 78-133, 138-139, 151
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           207       7  96.62%   116-117, 313, 340, 352, 359-360
R/module_init_data.R                 84       0  100.00%
R/module_nested_tabs.R              371      36  90.30%   163, 267-282, 302-306, 324, 361, 479-482, 486-489, 493-496
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         272       9  96.69%   302-306, 373, 376-378
R/module_source_code.R               69       0  100.00%
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            122       9  92.62%   60, 77-78, 81, 98, 128, 142, 144, 158
R/module_teal.R                     213       7  96.71%   130, 145-146, 186, 220, 263-264
R/module_transform_data.R           116       6  94.83%   48, 132-136
R/module_validate_error.R            73       0  100.00%
R/modules.R                         291      51  82.47%   170-174, 229-232, 356-376, 384, 390, 567-573, 586-594, 609-624
R/reporter_previewer_module.R        41      12  70.73%   41, 45, 68-85
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 20       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   298     298  0.00%    50-621
R/utils.R                           291      48  83.51%   402-451, 539-548
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58       0  100.00%
R/zzz.R                              19       0  100.00%
TOTAL                              3646     630  82.72%

Diff against main

Filename                         Stmts    Miss  Cover
-----------------------------  -------  ------  --------
R/module_bookmark_manager.R        -54     -55  +13.84%
R/module_filter_manager.R          -22     -43  +18.45%
R/module_init_data.R                 0      -6  +7.14%
R/module_nested_tabs.R               0      -1  +0.27%
R/module_snapshot_manager.R         +1    -185  +68.28%
R/module_teal.R                      0     -21  +9.86%
R/module_validate_error.R          +73       0  +100.00%
R/reporter_previewer_module.R        0     -29  +70.73%
R/validations.R                      0     -37  +63.79%
R/zzz.R                              0     -15  +78.95%
TOTAL                               -2    -392  +13.06%

Results for commit: 9e674a7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

m7pr · 2025-11-06T15:12:36Z

For now, covr stats, will try to improve

R/module_bookmark_manager.R: 28.76%
R/module_teal_data.R: 48.99%
R/module_snapshot_manager.R: 59.19%

…to covr

m7pr · 2025-11-06T16:36:32Z

Current:

teal Coverage: 72.94%

R/module_bookmark_manager.R: 25.49%
R/module_snapshot_manager.R: 83.82%
R/zzz.R: 100.00%

…to covr

tests/testthat/test-module_teal.R

m7pr · 2025-11-07T12:13:26Z

Current

teal Coverage: 76.49%
R/reporter_previewer_module.R: 0.00%
R/TealAppDriver.R: 0.00%
R/module_bookmark_manager.R: 25.49%
R/module_teal_data.R: 48.99%
R/module_teal_lockfile.R: 59.54%
R/after.R: 64.41%
R/module_filter_manager.R: 78.17%
R/modules.R: 82.47%
R/utils.R: 83.51%
R/module_snapshot_manager.R: 83.82%
R/module_teal.R: 86.85%
R/module_nested_tabs.R: 90.03%
R/module_teal_reporter.R: 92.62%
R/module_init_data.R: 92.86%
R/module_transform_data.R: 94.83%
R/module_data_summary.R: 95.48%
R/dummy_functions.R: 96.72%
R/init.R: 99.34%
R/checkmate.R: 100.00%
R/include_css_js.R: 100.00%
R/module_filter_data.R: 100.00%
R/module_session_info.R: 100.00%
R/module_source_code.R: 100.00%
R/teal_data_module-eval_code.R: 100.00%
R/teal_data_module-within.R: 100.00%
R/teal_data_module.R: 100.00%
R/teal_data_utils.R: 100.00%
R/teal_modifiers.R: 100.00%
R/teal_slices-store.R: 100.00%
R/teal_slices.R: 100.00%
R/teal_transform_module.R: 100.00%
R/validate_inputs.R: 100.00%
R/validations.R: 100.00%
R/zzz.R: 100.00%

…to covr

gogonzo · 2025-11-11T08:57:33Z

teal Coverage: 81.79%

gogonzo · 2025-11-11T14:55:02Z

R/module_filter_manager.R

        invisible(.self)
      })
    },
-    slices_deactivate_all = function(module_label) {


Removed as this method (in private class) is never used in whole NEST project. Please

gogonzo · 2025-11-11T14:57:17Z

R/module_validate_error.R

-#' @aliases ui_teal_data
-#' @note
-#' `ui_teal_data_module` was renamed from `ui_teal_data`.
-ui_teal_data_module <- function(id, data_module = function(id) NULL) {


removed as they are never used:

https://github.com/search?q=org%3Ainsightsengineering%20ui_teal_data_module&type=code

https://github.com/search?q=org%3Ainsightsengineering%20srv_teal_data_module&type=code

https://github.com/search?q=org%3Ainsightsengineering+ui_validate_reactive_teal_data&type=code

https://github.com/search?q=org%3Ainsightsengineering+srv_validate_reactive_teal_data&type=code

gogonzo · 2025-11-11T15:07:22Z

teal Coverage: 82.72%

module_bookmark_manager tests

133d6f7

m7pr added the core label Nov 6, 2025

m7pr and others added 3 commits November 6, 2025 13:25

Delete tests/testthat/test-module_bookmark_manager.R

9d9480b

Signed-off-by: Marcin <[email protected]>

more tests for snapshot manager and bookmark manager

0e628aa

remove skip

5c559e2

m7pr marked this pull request as ready for review November 6, 2025 12:47

m7pr changed the title ~~module_bookmark_manager tests [WIP]~~ module_bookmark_manager and module_snapshot_manager tests [WIP] Nov 6, 2025

m7pr and others added 7 commits November 6, 2025 16:17

ignore R/zzz.R

71a458e

tests for zzz.R

f62099e

[skip style] [skip vbump] Restyle files

8053af7

bring back tests for z zz.R

99381fb

Merge branch 'covr' of https://github.com/insightsengineering/teal in…

d638012

…to covr

extend bookmarking tests

cde50df

[skip style] [skip vbump] Restyle files

e306059

gogonzo self-assigned this Nov 7, 2025

m7pr changed the title ~~module_bookmark_manager and module_snapshot_manager tests [WIP]~~ zzz.R, module_bookmark_manager.R and module_snapshot_manager.R tests [WIP] Nov 7, 2025

m7pr changed the title ~~zzz.R, module_bookmark_manager.R and module_snapshot_manager.R tests [WIP]~~ [WIP] improve covr tests [WIP] Nov 7, 2025

m7pr and others added 7 commits November 7, 2025 12:29

add test-validations for validate_* functions

0df407d

add tests for deprecated functions validation

54f20ce

tests for report_previewer_module

06897df

delete test for deprecated funcionts

c008a08

ignore coverage of deprecated files

ff8d146

Merge branch 'covr' of https://github.com/insightsengineering/teal in…

db4bbd6

…to covr

[skip style] [skip vbump] Restyle files

2b9ccdb

m7pr and others added 3 commits November 7, 2025 12:51

teal_data_module tests

a6c74f8

Merge branch 'covr' of https://github.com/insightsengineering/teal in…

57da7ec

…to covr

[skip style] [skip vbump] Restyle files

2c8aab8

m7pr commented Nov 7, 2025

View reviewed changes

tests/testthat/test-module_teal.R Show resolved Hide resolved

m7pr and others added 12 commits November 7, 2025 13:25

test-reporter_previewer_module.R

084482e

Merge branch 'covr' of https://github.com/insightsengineering/teal in…

0dd71fb

…to covr

remove bookmarking tests. mark places for TODO

3e55ac8

comment out fishy AI tests

176d8aa

uncomment 3 tests

408e990

[skip style] [skip vbump] Restyle files

b160fa3

rewrite 2 tests so they expect a specific log message

74a2709

Merge branch 'covr' of https://github.com/insightsengineering/teal in…

89faa70

…to covr

[skip style] [skip vbump] Restyle files

6031170

cover snapshot manager

21afa04

remove redundant code

88fe006

increase coverage

35781ac

gogonzo added 2 commits November 11, 2025 15:38

isn't used in NEST repo

d5f0305

add more coverage in the filter_manager

9e674a7

gogonzo reviewed Nov 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[WIP] improve covr tests [WIP] #1646

[WIP] improve covr tests [WIP] #1646

m7pr commented Nov 6, 2025 •

edited

Loading

Uh oh!

m7pr commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

m7pr commented Nov 6, 2025

Uh oh!

m7pr commented Nov 6, 2025

Uh oh!

Uh oh!

m7pr commented Nov 7, 2025

Uh oh!

gogonzo commented Nov 11, 2025

Uh oh!

gogonzo Nov 11, 2025 •

edited

Loading

Uh oh!

gogonzo Nov 11, 2025

Uh oh!

gogonzo commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

[WIP] improve covr tests [WIP] #1646

Are you sure you want to change the base?

[WIP] improve covr tests [WIP] #1646

Conversation

m7pr commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m7pr commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

github-actions bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

m7pr commented Nov 6, 2025

Uh oh!

m7pr commented Nov 6, 2025

Uh oh!

Uh oh!

m7pr commented Nov 7, 2025

Uh oh!

gogonzo commented Nov 11, 2025

Uh oh!

gogonzo Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gogonzo Nov 11, 2025

Choose a reason for hiding this comment

Uh oh!

gogonzo commented Nov 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

m7pr commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 6, 2025 •

edited

Loading

github-actions bot commented Nov 6, 2025 •

edited

Loading

gogonzo Nov 11, 2025 •

edited

Loading