Add liger smoketest #591
Open
Add liger smoketest #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesKunstle
force-pushed
the
add-liger-smoketest
branch
from
bfb705b to
6f6a312
Compare
JamesKunstle
force-pushed
the
add-liger-smoketest
branch
from
6f6a312 to
86fba44
Compare
|
solves #462 |
booxter
approved these changes
Jun 4, 2025
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
booxter
force-pushed
the
add-liger-smoketest
branch
from
86fba44 to
d40e922
Compare
booxter
reviewed
Jun 4, 2025
tests/smoke/test_train.py
Outdated
| TorchrunArgs, | ||
| TrainingArgs, | ||
| ) | ||
| from instructlab.training.main_ds import run_training | ||
|
|
||
| MINIMAL_TRAINING_ARGS = { | ||
| "max_seq_len": 140, # this config fits nicely on 4xL40s and may need modification for other setups | ||
| "max_batch_len": 15000, |
There was a problem hiding this comment.
are these parameters' changes intentional? why?
|
Is the idea behind the param changes that this could run on a smaller ec2 instance? Should we also update the workflow file in this pr? |
|
@Mergifyio rebase |
runs through Liger w/ and w/o CPUOffload parameterizes LoRA but doesn't enable it because of memory usage bug removes `smoketest.sh` from `tests` directory- all tests should use pytest in the future. Signed-off-by: James Kunstle <[email protected]>
Let's see if there's any issue without these changes. If not, we can cancel / postpone changes to a separate PR. Signed-off-by: Ihar Hrachyshka <[email protected]>
✅ Branch has been successfully rebased |
booxter
force-pushed
the
add-liger-smoketest
branch
from
8aad472 to
a3e0fde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #590 to be merged first- this PR is based on that one
Closes #462