Fix docker_dev_setup script on Linux: status check #2545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systemd machines without the
servicecommand available, docker will always appear to not be running.The file
script/common/os/linux/impl.shwill attempt to run the following command to check the status of docker:sudo systemctl docker status # this returns an error, always--the arguments are in the wrong orderI suggest we use
docker infoinstead. This command will return an error code if docker is inactive and success if docker is active. Alternatively, the arguments should be properly arranged forservicevssystemctl.