Added "offset" to Result. #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working with the SDK, I realized that there is no way to get the offset, so if you don't retain that when passing it to the SDK for querying, the value is lost. * Added a new "private" field, `_offset`, which holds the offset value from the result XML, if it is present. * Added a public getter for the `_offset` field. * Updated the constructor so that if the Result XML has an `offset` attribute, it attempts to parse it to an integer and then set it to the `_offset` field. * Updated ResultTest to add tests for the expected `offset` data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with the SDK, I realized that there is no way to get the offset, so if you don't retain that when passing it to the SDK for querying, the value is lost.
_offset, which holds the offset value from the result XML, if it is present._offsetfield.offsetattribute, it attempts to parse it to an integer and then set it to the_offsetfield.offsetdata.