[SYCL][NATIVECPU][PERF] always inline kernels with -O3 #17360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedolinsky
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
hvdijk
reviewed
Mar 7, 2025
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
changed the title
uwedolinsky
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
hvdijk
reviewed
Sep 24, 2025
| auto *NewF = | ||
| cloneFunctionAndAddParam(OldF, StatePtrType, CurrentStatePointerTLS); | ||
| NewF->setLinkage(llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage); | ||
| if (O3 && !NewF->hasFnAttribute(Attribute::NoInline)) { |
There was a problem hiding this comment.
Does this need to be limited to -O3 or could we do if (!NewF->hasOptNone() && !NewF->hasFnAttribute(Attribute::NoInline)) ?
(If we do want it to be limited to -O3, I think it'd be slightly better to have OptLevel as the field that we store in the pass, and check OptLevel == OptimizationLevel::O3 here, but I'm thinking we want it at other levels too.)
There was a problem hiding this comment.
Also, do we know why the regular inliner doesn't handle this?
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlines kernels into subhandler when compiling for -O3, and removes the kernels if inlining succeeded.