Skip to content

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Aug 28, 2025

@sarnex sarnex marked this pull request as ready for review August 28, 2025 20:32
@sarnex sarnex requested a review from a team as a code owner August 28, 2025 20:32
@sarnex
Copy link
Contributor Author

sarnex commented Aug 29, 2025

Ping @intel/bindless-images-reviewers, thanks!

@sarnex sarnex merged commit 18fc2f6 into intel:sycl Sep 2, 2025
69 of 71 checks passed
@vmaksimo
Copy link
Contributor

vmaksimo commented Sep 9, 2025

@sarnex i'm a bit confused here - why did we marked the test run as unsupported if it started to pass? (investigating #19586)

@sarnex
Copy link
Contributor Author

sarnex commented Sep 9, 2025

@vmaksimo Sorry, the description wasn't complete. The test still fails in precommit and/or postcommit but passes in the nightly, so make it unsupported so it works in both

I actually didn't test it in precommit/postcommit recently and often XFAILS are changed to UNSUPPORTED because we test on multiple devices in precommit, so it could be passing in precommit too, but it was definitely failing at the time the XFAIL was first added.

Feel free to try removing the UNSUPPORTED and see what happens

@vmaksimo
Copy link
Contributor

Thanks @sarnex! Trying this in #20043

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants