[UR][L0] Refine default device logic in urDeviceGet #20036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlemkows
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wlemkows
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
wlemkows
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wlemkows
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Unrelated issue: Should be fixed by: |
kswiecicki
reviewed
Sep 11, 2025
pbalcer
reviewed
Sep 15, 2025
| @@ -1462,6 +1353,143 @@ ur_result_t urDeviceGetInfo( | |||
| return UR_RESULT_SUCCESS; | |||
| } | |||
|
|
|||
| ur_result_t urDeviceGet( | |||
There was a problem hiding this comment.
This is hard to review because you moved the function. Can you move it back?
wlemkows
force-pushed
the
get-device-ur
branch
from
0da83a4 to
7081a4e
Compare
wlemkows
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wlemkows
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wlemkows
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kswiecicki
reviewed
Sep 16, 2025
| // In case of DeviceType is DEFAULT, pick only the most powerful GPU | ||
| // device. | ||
| if (DeviceDefaultGPU) { | ||
| uint32_t maxComputeUnits = 0; |
There was a problem hiding this comment.
nit: I'm not sure if it wouldn't be cleaner to just collect matched devices here, and then outside this loop, if DeviceType == UR_DEVICE_TYPE_DEFAULT, iterate over them to select the best single GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.