[UR] Do not call urDeviceRetain() in case of subdevices #20065
+52
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ldorau
force-pushed
the
Do_not_call_DeviceRetain_in_constructor_of_device_impl
branch
from
b07c1d4 to
51a4b37
Compare
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
ldorau
force-pushed
the
Do_not_call_DeviceRetain_in_constructor_of_device_impl
branch
from
51a4b37 to
ab4b9b9
Compare
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ldorau
changed the title
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ldorau
force-pushed
the
Do_not_call_DeviceRetain_in_constructor_of_device_impl
branch
from
ab4b9b9 to
7c033d0
Compare
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
ldorau
force-pushed
the
Do_not_call_DeviceRetain_in_constructor_of_device_impl
branch
from
7c033d0 to
054acf1
Compare
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
ldorau
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
There is no need to call urDeviceRetain(MDevice) in constructor of device_impl in case of subdevices. It fixes URT-961. Signed-off-by: Lukasz Dorau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to call urDeviceRetain(MDevice)
in constructor of device_impl in case of subdevices.
It fixes URT-961.