[NFC][SYCL] Reduce dependencies of sycl/multi_ptr.hpp
#20073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
commented
Sep 12, 2025
| @@ -8,17 +8,18 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <sycl/access/access.hpp> // for address_space, decorated | |||
| #include <sycl/aliases.hpp> // for half | |||
| #include <sycl/detail/fwd/multi_ptr.hpp> | ||
| #include <sycl/detail/type_traits.hpp> // for const_if_const_AS | ||
| #include <sycl/half_type.hpp> // for BIsRepresentationT |
There was a problem hiding this comment.
...and this are being removed.
There was a problem hiding this comment.
and yet we are adding new includes to other files? builtins.hpp is being changed to now include multi_ptr.hpp ;-)
If it makes a difference in the compile times, I'm 100% supporting
There was a problem hiding this comment.
We don't :) This PR is in the draft state because its first commit is being reviewed separately at #20074. That is where the addition is being done.
aelovikov-intel
force-pushed
the
multi-ptr-deps
branch
from
598ce55 to
6d9aa04
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
force-pushed
the
multi-ptr-deps
branch
from
6d9aa04 to
4f05aa2
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Sep 12, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
force-pushed
the
multi-ptr-deps
branch
from
4f05aa2 to
8703ae4
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.