[NFC][SYCL] Cleanup marray/vector includes
#20181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlights: * No `<exception>` for device compilation * limit `half`/`bfloat16` to forward declarations * `is_device_copyable.hpp` is lightweight but it triggers an FE bug when using PCH for device code, so I limited it to forward declaration for now too. * Remove duplicate/redundant includes
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Sep 24, 2025
| typedef __fp16 h2 ATTRIBUTE_EXT_VEC_TYPE(2); | ||
| auto rv = __nvvm_ldg_h2(reinterpret_cast<const h2 *>(ptr)); | ||
| sycl::vec<half, 2> ret; | ||
| T ret; |
There was a problem hiding this comment.
Just makes this statement template-type-dependent, so we don't need a definition of half unless the caller used it (and hence already had it).
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
approved these changes
Sep 24, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Sep 25, 2025
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
<exception>for device compilationhalf/bfloat16to forward declarationsis_device_copyable.hppis lightweight but it triggers an FE bug when using PCH for device code, so I limited it to forward declaration for now too.