-
Notifications
You must be signed in to change notification settings - Fork 282
Update AutoRound layer_config usage
#2331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Kaihui-intel <[email protected]>
Signed-off-by: Kaihui-intel <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Kaihui-intel <[email protected]>
| lm_head_config = RTNConfig(dtype="fp32") | ||
| quant_config.set_local("lm_head", lm_head_config) | ||
| ``` | ||
| 3. Example of using `layer_config` for AutoRound |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 'set_local' does not work in current implementation, we should call out this, let user know, AutoRound specific 'layer_config' instead of 'set_local' API should be used. since in AutoRoundConfig, not any one of 3 items work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code will be raised in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do u mean you will implement 'set_local' support by converting it to layer_config so any of 3 options is valid after your another PR merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. Currently, only the third option is supported. option `1, 2 'will be implemented in phase 2.
User description
Type of Change
documentation
Description
detail description
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed
PR Type
Documentation
Description
Added
schemeandlayer_configto AutoRound documentationProvided example usage of
layer_configfor AutoRoundDiagram Walkthrough
File Walkthrough
PT_WeightOnlyQuant.md
Document `scheme` and `layer_config` for AutoRounddocs/source/3x/PT_WeightOnlyQuant.md
schemeandlayer_configto tablelayer_configfor AutoRound