Remove unused variables #2044
Merged
Remove unused variables #2044
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused variables from the codebase and adds a compiler flag to detect unused variables in the future. The changes focus on cleaning up variables that were declared but never referenced in the code.
- Removes unused
output_sizevariable from RoiAlign kernel - Removes unused
dg_dataanddb_datavariables from LayerNorm backward kernel - Adds
-Werror=unused-variablecompiler flag to catch future unused variables
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/RoiAlignKernels.cpp | Removes unused output_size variable calculation |
| src/ATen/native/xpu/sycl/LayerNormKernels.cpp | Removes unused pointer variables dg_data and db_data |
| CMakeLists.txt | Adds compiler flag to treat unused variables as errors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CuiYifeng
reviewed
Sep 19, 2025
guangyey
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
guangyey
approved these changes
Sep 22, 2025
chuanqi129
approved these changes
Sep 22, 2025
mengfei25
pushed a commit
to mengfei25/torch-xpu-ops
that referenced
this pull request
Sep 29, 2025
- remove unused variables, - add compiler flag to prevent this in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.