Enable FP8 compare_xpu #2154
Open
Enable FP8 compare_xpu #2154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables FP8 (8-bit floating point) dtype support for comparison operations on XPU devices. The changes update both the kernel implementation and test suite to handle the new float8 types introduced in PyTorch.
Key changes:
- Extended comparison kernel dispatcher to include all float8 dtypes (e5m2, e4m3fn, e4m3fnuz, e5m2fnuz, e8m0fnu)
- Enhanced test coverage to validate comparison operations across all float8 types
- Updated test infrastructure to use float32 CPU references for float8 comparisons
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ATen/native/xpu/sycl/CompareKernels.cpp | Replaced AT_DISPATCH_ALL_TYPES_AND3 with AT_DISPATCH_V2 to include float8 dtypes |
| test/regressions/test_compare.py | Added comprehensive float8 dtype test coverage with proper CPU reference handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #1939