Ensured that output tensors (output and indices) correctly propagate the names from the input tensor #2281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for named tensors to the max_pool3d_with_indices_xpu implementation by ensuring proper propagation of tensor names from input to output tensors.
- Includes necessary header for named tensor utilities
- Propagates tensor names from input to both output and indices tensors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chunhuanMeng
changed the title
CuiYifeng
approved these changes
Nov 4, 2025
Contributor
CuiYifeng
left a comment
CuiYifeng
left a comment
There was a problem hiding this comment.
LGTM. Please indicate which test cases will be fixed by this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2023
Makes improvements to the
max_pool3d_with_indices_xpuimplementation by enhancing support for named tensors and ensuring proper propagation of tensor names. The changes also include a minor code organization update.Enhancements for named tensor support:
ATen/NamedTensorUtils.hinDilatedMaxPool3d.cppto enable named tensor utilities.outputandindices) correctly propagate the names from the input tensor by callingnamedinference::propagate_namesfor both.