Develop #11

adrianboros · 2025-09-27T18:06:56Z

No description provided.

…nt in body of request to rafiki pos service sync amount and receiverWalletAddress to be the values set by the merchant

…purposes

feat(kaios-pos): add qr code reading + add payment to rafiki as test

App UI updates

Test

golobitch · 2025-09-27T20:14:05Z

src/components/ErrorBoundary.tsx

  render() {
    return this.state.hasError ? (
      <div className="p-6 text-center">
        <h2 className="text-xl font-semibold">Something went wrong</h2>


Both these two lines have hardcoded text? Not localized?

golobitch · 2025-09-27T21:14:36Z

src/pages/EndOfDay.tsx

+        ))}
+        {!items.length && (
+          <div className="px-3 py-6 text-center text-white-60">
+            No transactions for this date.


golobitch · 2025-09-27T21:14:46Z

src/pages/EndOfDay.tsx

+        )}
+        {items.length > 0 && (
+          <div className="rounded-4xl bg-green-500 mt-6 px-6 py-6 text-center text-white">
+            <span data-l10n-id="email-report">Email report</span>


golobitch · 2025-09-27T21:16:20Z

src/pages/Language.tsx

+  const inputRef = useRef<HTMLSelectElement>(null);
+
+  const availableLanguages = [
+    { code: "en-US", label: "English" },


I think that this labels should be translated :) ro-RO would be Romanian in English language :)

golobitch · 2025-09-27T21:17:23Z

src/pages/Language.tsx

+    }
+  }, []);
+
+  useEffect(() => {


Can we somehow not duplicate this code? Because I see that this one is quite duplicated

golobitch · 2025-09-27T21:18:00Z

src/pages/PaymentPointer.tsx

+    <section className="space-y-2">
+      <Header />
+      <div className={`flex flex-col p-4 mt-4 ${0 === focused ? "active-item-bg" : ""}`}>
+        <span className="">Payment pointer</span>


Translation - Payment pointer

golobitch · 2025-09-27T21:20:34Z

src/pages/SetupByQR.tsx

+      };
+
+      if (typeof paymentPointer !== "string" || paymentPointer.trim() === "") {
+        throw new Error("paymentPointer missing in QR code");


Translate error

golobitch · 2025-09-27T21:20:42Z

src/pages/SetupByQR.tsx

+        throw new Error("paymentPointer missing in QR code");
+      }
+      if (typeof signSec !== "string" || signSec.trim() === "") {
+        throw new Error("signSec missing in QR code");


Translate error

golobitch · 2025-09-27T21:20:56Z

src/pages/SetupByQR.tsx

+      console.log("[SetupByQR] stored QR settings");
+    } catch (err) {
+      const message =
+        err instanceof Error ? err.message : "Invalid QR configuration payload";


Translate error

golobitch · 2025-09-27T21:21:05Z

src/pages/SetupByQR.tsx

+    const videoEl = videoRef.current;
+
+    if (!videoEl) {
+      setError("Video element not available.");


golobitch · 2025-09-27T21:21:13Z

src/pages/SetupByQR.tsx

+    const canvas = document.createElement("canvas");
+    const context = canvas.getContext("2d");
+    if (!context) {
+      setError("Unable to access canvas context.");


golobitch · 2025-09-27T21:21:28Z

src/pages/SetupByQR.tsx

+            setError(
+              parseError instanceof Error
+                ? parseError.message
+                : "Unable to process QR",


golobitch · 2025-09-27T21:21:38Z

src/pages/SetupByQR.tsx

+
+    const handleError = (err: unknown) => {
+      const message =
+        err instanceof Error ? err.message : "Unable to access camera.";


golobitch · 2025-09-27T21:21:49Z

src/pages/SetupByQR.tsx

+          },
+        );
+      } else {
+        handleError(new Error("Camera API is not available on this device."));


golobitch · 2025-09-27T21:21:57Z

src/pages/SetupByQR.tsx

+      style={{ minWidth: 0 }}
+    >
+      <header className="text-xl font-semibold" data-l10n-id="setup-qr-title">
+        Setup by QR


golobitch · 2025-09-27T21:22:05Z

src/pages/SetupByQR.tsx

+        {decodedValue ? (
+          <div>
+            <div className="font-semibold" data-l10n-id="setup-qr-result-label">
+              QR Data


golobitch · 2025-09-27T21:22:16Z

src/pages/SetupByQR.tsx

+          </div>
+        ) : (
+          <div className="text-gray-600" data-l10n-id="setup-qr-instructions">
+            {isScanning


golobitch · 2025-09-27T21:22:20Z

src/pages/SetupByQR.tsx

+          className="text-sm text-gray-600"
+          data-l10n-id="setup-qr-no-result"
+        >
+          No QR code detected.


golobitch · 2025-09-27T21:22:34Z

src/pages/Splash.tsx

      <div className="text-center">
-        <div className="text-4xl font-extrabold tracking-tight">
+        <div className="mt-12 pt-8 pb-8">
+          <img src="/assets/icons/logo.png" alt="Interledger POS" className="mx-auto" />


Translate alt text

golobitch · 2025-09-27T21:24:07Z

src/pages/WaitCard.tsx

-      <p className="mt-2 text-white/70">
-        Waiting for an NFC card… keep it in the field until confirmed.
-      </p>
+      <Header title="Waiting for Card" />


golobitch · 2025-09-27T21:24:40Z

src/pages/WaitCard.tsx

+          </p>
+        )}
+
+        <span data-l10n-id={`statuses-${transactionStatus}-key-message`} className="mt-4 mb-2 px-4 text-xl text-center">Hold card near the reader</span>


* feat: pin page, pin component and state logic * feat: extract a TransactionStatus component

…n status options, and also integrates the pin component (#14)

* feat: language page update, menu icon and translations updates * fix: remove language hint as not needed

* feat(gpo-rr): implement gpo and read record apdu commands * feat(pos): introduce GPO and RR commands & general refactor

* feat(kaios-pos): add 9f36, df01, df02, and wrap all in 77 * chore(kaios-pos): remove clogs

beniaminmunteanu and others added 16 commits September 16, 2025 21:16

initial commit of first apdu commands

397a5fd

adhere to new format of cdol1, create payment object that is to be se…

b64211e

…nt in body of request to rafiki pos service sync amount and receiverWalletAddress to be the values set by the merchant

fix: wip UI work, translation support, remove tailwind

f29836d

Merge remote-tracking branch 'origin/first-apdu-commands' into develop

a3f1682

fix(pages): UI updates on balance, eod pages and other improvements

6f51c8d

fix(pages): make app UI close with KaiOs design style

353d38e

fix: some cleanup

fcaf53d

fix: remove unused files

ba9e8b6

feat(kaios-pos): add qr code reading + add payment to rafiki for dev …

3080a88

…purposes

chore(qr): remove dead comment

7c82520

Merge pull request #9 from interledger/qr-code

c6e824b

feat(kaios-pos): add qr code reading + add payment to rafiki as test

fix(locale): add language select setting page and functionlity

aab9e7a

Merge branch 'develop' into wip-ui-pages-updates

59b473c

fix: move qr page to settings for now

a53c112

fix: remove doamne ajuta from the menu

e264bb4

Merge pull request #8 from interledger/wip-ui-pages-updates

37441fd

App UI updates

adrianboros requested review from beniaminmunteanu, dragosp1011 and golobitch September 27, 2025 18:07

fix: remove release zip file from git

9c5c497

golobitch previously approved these changes Sep 27, 2025

View reviewed changes

golobitch self-requested a review September 27, 2025 18:47

golobitch previously approved these changes Sep 27, 2025

View reviewed changes

golobitch reviewed Sep 27, 2025

View reviewed changes

src/pages/SetupByQR.tsx

setError(

parseError instanceof Error

? parseError.message

: "Unable to process QR",

Copy link

Collaborator

golobitch Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate

golobitch reviewed Sep 27, 2025

View reviewed changes

src/pages/SetupByQR.tsx

},

);

} else {

handleError(new Error("Camera API is not available on this device."));

Copy link

Collaborator

golobitch Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translate

golobitch reviewed Sep 27, 2025

View reviewed changes

chore(locale): setup a folder structure for crowdin

a430a26

golobitch dismissed their stale review via a430a26 September 28, 2025 16:37

golobitch and others added 13 commits September 28, 2025 18:41

Update Crowdin configuration file

801a34b

Update Crowdin configuration file

c8ca34e

fix(locale): line break

0eed0bc

fix: small cleanup

b598bea

fix: small cleanup and fix translations file renaming issue

39cca43

Feat/pin page (#13)

7eec49a

* feat: pin page, pin component and state logic * feat: extract a TransactionStatus component

feat(pos): the payment flow now makes use of the different transactio…

91eb5c4

…n status options, and also integrates the pin component (#14)

feat: language page update, menu icon and translations updates (#15)

86823b5

* feat: language page update, menu icon and translations updates * fix: remove language hint as not needed

feat(payload): added mandatory fields in tlv data + pin block (#17)

d835973

feat(kaios-pos): introduce GPO and read record - general refactor (#18)

3c87ea3

* feat(gpo-rr): implement gpo and read record apdu commands * feat(pos): introduce GPO and RR commands & general refactor

feat(kaios-pos): add 9f36, df01, df02, and wrap all in 77 (#19)

a1cc75e

* feat(kaios-pos): add 9f36, df01, df02, and wrap all in 77 * chore(kaios-pos): remove clogs

fix: small fixes (#20)

cdc63ff

fix(pos-device): add currency code and various fixes

aff4d70

Develop #11

Are you sure you want to change the base?

Develop #11

Uh oh!

Conversation

adrianboros commented Sep 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants